Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4D6FantasySheet.html #12837

Merged
merged 1 commit into from May 15, 2024
Merged

Update 4D6FantasySheet.html #12837

merged 1 commit into from May 15, 2024

Conversation

McnabbGames
Copy link
Contributor

Fixed Formatting issues that affected Dice Roll Buttons

Submission Checklist

Required

  • [x ] The pull request title clearly contains the name of the sheet I am editing.
  • [ x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • [ x] The pull request makes changes to files in only one sub-folder.
  • [ x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • [ x] I have followed the Character Sheets Standards when building this sheet.

  • [x ] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Fixed Formatting issues that broke Roll Buttons

Fixed Formatting issues that affected Dice Roll Buttons
@McnabbGames McnabbGames requested a review from a team as a code owner April 26, 2024 03:40
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@BronsonHall
Copy link
Contributor

Hey @McnabbGames ,

This all looks good to merge - but seems we missed something in your last PR, hence the translation.json invalid failing check here. We think the trailing comma on the last translation is to blame; if you wouldn't mind removing that in this PR, it'll fix your translation.json and pass the check. Thanks!

@BronsonHall
Copy link
Contributor

Hey @McnabbGames

Checking in again here, we need a small correction to the translation.json before we can merge this or future PRs for this sheet.
Please let me know if you have any questions

@McnabbGames
Copy link
Contributor Author

McnabbGames commented May 15, 2024 via email

@BronsonHall BronsonHall merged commit 8865aab into Roll20:master May 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants