Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Shaped character sheet for The Wildsea RPG #12822

Closed
wants to merge 30 commits into from

Conversation

austinmh12
Copy link

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: The Wildsea RPG (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: Quillhound Studios (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: 13th Age (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.
    Somewhat, I know a Wildsea RPG sheet already exists, which goes against the ask Ideally, don't submit sheets for games that already has a sheet. but it seemed like a better idea to do this than to rewrite the entirety of the other sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Created a custom sheet from scratch to closely mimic the shape of the Wildsea official character and ship sheets using the new sheet styling and available jquery ( $20 ) to handle updating attributes. The only unimplemented thing is the ability to "burn" an aspect/crew track as the roll20query does not allow for the updating of a class in a repeating item in the way that I was attempting.

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@austinmh12
Copy link
Author

Is that check failing because the folder name is WildseaShaped instead of one of the values in that approved.yaml file under Wildsea?

@BronsonHall
Copy link
Contributor

Hey @austinmh12

Yep, the check's failing because it can't find the sheet folder in the approved.yaml; but you don't need to worry about that, we add each new sheet to the approved.yaml shortly before we merge them with proper folder, game & system names. That check always fails for new sheets until we set it up on our end - really just a reminder for us.

That said though, as you did mention in this PR, there is another existing community sheet for this game, which goes against our usual policy. We traditionally bend this rule in a couple cases, namely when a publisher submits a sheet for their own game, or when a sheet is submitted for a 'version' of the base game that is mechanically incompatible. (example here - a newer edition of a system is released that changes some rules, but keeps the same title. We might allow both an existing sheet and a new sheet to exist in this case, as active campaigns may want to keep using the old ruleset.)

This instance is a bit more tricky - this sheet has significant functionality boosts and visual improvements over the existing sheet, but is made for the same ruleset, mechanically. The 'one game - one sheet' rule was originally made in the interest of encouraging collaboration and simplifying sheet selection. But it's been clear in the past that, in cases like these, it can often be a lot more work to make a sheet into an upgrade rather than a stand-alone alternative, due to the added requirement of maintaining existing user data from the old sheet. Nonetheless, that's definitely the ideal scenario, insofar as the repo is concerned.

If you wouldn't mind, I'd ask that you take a quick look, and just scope out how much work it'd be to make this an update instead.

You could effectively replace the whole old codebase with the new, provided that - crucially - all attributes are kept, either being transferred to a new attribute name via an update sheet worker or given the same name on the new sheet. This includes repeating sections if possible. We'd also then give a courtesy period for the old author to review and approve the changes.

If it looks like it'd be too much, or if the two sheets just functionally do not line up, let me know. Either way, I'm going to discuss this all with the team tomorrow and get back to you.

Thanks for your patience!

@austinmh12
Copy link
Author

Thanks for the detailed response on this, I've been doing some comparisons between both the sheets to see what it would take to adapt this version into the existing one in the least intrusive way. It doesn't seem like it would be an egregious amount of work, I would just have to adjust some free text areas to be repeating sections and adjust attribute names. I'll try to reach out to the authors of the original sheet to see what they think and try to move forward from there.

@austinmh12 austinmh12 closed this May 14, 2024
@austinmh12
Copy link
Author

Closing because I'm polishing up changes to the existing wildsea character sheet and will be reaching out to the other authors once I finish with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants