Adds a new menu item "Favorite Locations" in the navigation. #2552

Ditto-IV100 · 2018-03-26T21:32:09Z

Description

This will insert a new menu item "Favorite Locations" in the navigation with three functions:

with the first function, users can search for places like neighborhoods, streets, etc. (This code was already in RM. I only changed it a bit.)
the second function allows the user to save the current view as "quick button". Each view can be assigned an own name. This buttons can be deleted again at any time by the user.
and the third feature allows the site admins to leave predefined locations as "quick button". These can be stored as deletable or non-deletable buttons. The predefined gps coordinates are stored in the custom.js
A few examples:
(result see Screenshots)

const 'favoriteLocations' = [{
        'Amsterdam': {lat: 52.3702157, lng: 4.8951678, zoom: 13, deletable: false},
        'Central Park (NY)': {lat: 40.7828647, lng: -73.9653551, zoom: 16, deletable: false},
        'London': {lat: 51.5073509, lng: -0.1277582, zoom: 14, deletable: true},
        'Berlin': {lat: 52.5200065, lng: 13.4049539, zoom: 14}
    }]

Motivation and Context

These functions are very helpful to save hotspots like nests, or if the site admin scans only some places (or a large area), he can deposit these places as a "quick button". The places created by the user are stored in the localstorage and will not be publicly available. Therefore, my other PR (#2545) is very useful to restore the settings in case of loss.

How Has This Been Tested?

I use it on my map. I just changed it a bit for publishing and to make it more user-friendly.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

pogo-excalibur · 2018-03-26T22:53:45Z

static/js/map.common.js

+    },
+    'favoritesLocations': {
+        default: [{
+            'Amsterdam': {lat: 52.3702157, lng: 4.895167899999933, zoom: 13, deletable: false},


Just leave the default list blank.

no problem, but then we need a documentation :)

Yes - add an example to custom.js.example

pogo-excalibur · 2018-03-26T22:55:44Z

static/js/map.js

+        googleSearchBox.addListener('place_changed', function () {
+            var place = googleSearchBox.getPlace()
+
+            if (!place.geometry) return


Because we're not using semicolons, please use:

if (!place.geometry) { return }

This is a code snippet from RM itself. But I can change that.

pogo-excalibur · 2018-03-26T23:01:30Z

static/js/map.js

+ * Favorit-location
+ * first run load locations from settings / localStorage
+*/
+function initFavoLocation() {


initFavoLocation -> initFavoriteLocations

pogo-excalibur · 2018-03-26T23:02:43Z

static/js/map.common.js

@@ -1065,6 +1065,15 @@ var StoreOptions = {
    'isSearchMarkerMovable': {
        default: false,
        type: StoreTypes.Boolean
+    },
+    'favoritesLocations': {


favoritesLocations -> favoriteLocations

pogo-excalibur · 2018-03-26T23:07:46Z

templates/map.html

@@ -427,6 +427,46 @@ <h3>Use Pokémon cries</h3>
              </div>
          </div>
            {% endif %}
+
+          <h3><i class="fa fa-binoculars fa-fw"></i>Favorites Locations</h3>


This should probably be under 'Location & Search Settings'.

For the overview I have separated it, but if it is desired I can do that. It would fit in there too

Is it a seperate category alongside 'Marker Settings', 'Location & Search Settings' etc?

(If so then leave it for now)

yes, I would say

pogo-excalibur · 2018-03-26T23:11:23Z

static/js/map.js

+
+    var searchLocationInput = document.getElementById('search-favorit-location-input')
+    if (searchLocationInput) {
+        var googleSearchBox = new google.maps.places.Autocomplete(searchLocationInput)


Is it possible to specify a locality here, using the location specified in the config?

Setting the locality helps reduce errors caused by multiple places with the same name.

Well this part is from RM and uses the google API. I do not know if you can do something like that. But basically this is a google search and the locality is displayed.

So from memory Google allows you to pick a location to find results near.

e.g. If you were in London, Ohio (in the US) setting the locality to 'United States' would give you the result that you were looking for: London, Ohio, US, rather than the more searched-for: London, UK.

Now it would look like this.

It's like "Change search location" which already exists in RM.

I do not know how I have to change that in the google-maps-api so it is focused on the location from the settings. But I do not think that this option is really necessary.

OK. Leave this for now then.

pogo-excalibur · 2018-03-26T23:13:59Z

You've misspelt 'favorite' throughout. Perhaps a language issue?

Ditto-IV100 · 2018-03-26T23:32:03Z

Possible.. my native language is not english..

darkelement1987 · 2018-03-26T23:39:18Z

Also 'Favorite Locations' can be 'Favorite locations' and 'Search location' here (lowercase)

Ditto-IV100 · 2018-03-27T00:09:08Z

@pogo-excalibur
Apply changes

darkelement1987 · 2018-03-27T08:39:29Z

I'd suggest changing the 'floppydisk' icon to a 'plus'-symbol. And maybe a few px's space between buttons/textfields? Just for the eye :p

Ditto-IV100 · 2018-03-27T13:35:48Z

@darkelement1987 why not a floppydisk?

~~I found a bug, if no location is is preset. I will fix it.~~ - done

support for custom.js

captbunzo · 2018-03-27T15:11:54Z

Great feature btw. Similar to something I've done with custom.js on my map, but better! 👍

pogo-excalibur · 2018-03-27T17:06:31Z

static/js/custom.js.example

@@ -11,6 +11,10 @@ $(function () {
    const upscalePokemon = false // Enable upscaling of certain Pokemon (upscaledPokemon and notify list). Default: false.
    const upscaledPokemon = [] // Add Pokémon IDs separated by commas (e.g. [1, 2, 3]) to upscale icons. Default: [].

+    // Add predefined buttons for favorit location


favorit -> favorite

And because this is an example file you don't need to use a comment to specify the format, you can just use code:

const favoriteLocations = [ { lat: 40.7828647, lng: -73.9653551, zoom: 16, deletable: false } ]

pogo-excalibur · 2018-03-27T17:17:29Z

static/js/custom.js.example

@@ -83,6 +87,10 @@ $(function () {
    Store.set('showLocationMarker', showLocationMarker)
    Store.set('isLocationMarkerMovable', isLocationMarkerMovable)

+    if (Store.get('favoriteLocations')[0] === undefined) {


Is the intention here to check if there are any favoriteLocations set?

If so use if (Store.get('favoriteLocations').length === 0) {

this is also a possibility – done

pogo-excalibur · 2018-03-27T17:34:15Z

static/js/map.js

@@ -509,6 +509,134 @@ function initSidebar() {
    }

    $('#pokemon-icon-size').val(Store.get('iconSizeModifier'))
+
+    $('#add-favorit-location-button').on('click', function () {


favorit -> favorite

(This needs changing throughout)

you still found something.. shame on me :-/

Ditto-IV100 added 4 commits March 25, 2018 16:22

add functionality for favorites locations

452c7a5

Merge branch 'develop' into favorites-locations

913653a

change the name of variants

2161ae6

Changes to the order in the menu

c118676

pogo-excalibur reviewed Mar 26, 2018

View reviewed changes

Ditto-IV100 added 3 commits March 27, 2018 01:55

code fixed

2a66a27

Spelling correction

e13ba57

code fixed

2b5e7b3

Ditto-IV100 changed the title ~~Adds a new menu item "Favorites Locations" in the navigation.~~ Adds a new menu item "Favorite Locations" in the navigation. Mar 27, 2018

Ditto-IV100 added 3 commits March 27, 2018 02:53

add favorite location example

de6eedb

bug fixed

0168266

code fixed

caa4b1c

Ditto-IV100 added 3 commits March 27, 2018 16:01

bug fixed

c0349a8

bug fixed

278b608

support for custom.js

add a few px's space between buttons

7e3c7bf

pogo-excalibur reviewed Mar 27, 2018

View reviewed changes

Ditto-IV100 added 4 commits March 27, 2018 21:25

spelling correction

e686d63

example update

9a0c5d0

code update

42a3367

spelling correction

4da7d0a

darkelement1987 approved these changes Mar 27, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a new menu item "Favorite Locations" in the navigation. #2552

Adds a new menu item "Favorite Locations" in the navigation. #2552

Ditto-IV100 commented Mar 26, 2018 •

edited

pogo-excalibur Mar 26, 2018

Ditto-IV100 Mar 26, 2018

pogo-excalibur Mar 26, 2018 •

edited

Ditto-IV100 Mar 27, 2018

pogo-excalibur Mar 26, 2018

Ditto-IV100 Mar 26, 2018

pogo-excalibur Mar 26, 2018

pogo-excalibur Mar 26, 2018

pogo-excalibur Mar 26, 2018

Ditto-IV100 Mar 26, 2018

pogo-excalibur Mar 26, 2018 •

edited

Ditto-IV100 Mar 26, 2018

pogo-excalibur Mar 26, 2018

Ditto-IV100 Mar 26, 2018

pogo-excalibur Mar 27, 2018

Ditto-IV100 Mar 27, 2018 •

edited

pogo-excalibur Mar 27, 2018

pogo-excalibur commented Mar 26, 2018

Ditto-IV100 commented Mar 26, 2018

darkelement1987 commented Mar 26, 2018

Ditto-IV100 commented Mar 27, 2018

darkelement1987 commented Mar 27, 2018 •

edited

Ditto-IV100 commented Mar 27, 2018 •

edited

captbunzo commented Mar 27, 2018

pogo-excalibur Mar 27, 2018

pogo-excalibur Mar 27, 2018

Ditto-IV100 Mar 27, 2018

pogo-excalibur Mar 27, 2018

Ditto-IV100 Mar 27, 2018

Adds a new menu item "Favorite Locations" in the navigation. #2552

Are you sure you want to change the base?

Adds a new menu item "Favorite Locations" in the navigation. #2552

Conversation

Ditto-IV100 commented Mar 26, 2018 • edited

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pogo-excalibur Mar 26, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pogo-excalibur Mar 26, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ditto-IV100 Mar 27, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pogo-excalibur commented Mar 26, 2018

Ditto-IV100 commented Mar 26, 2018

darkelement1987 commented Mar 26, 2018

Ditto-IV100 commented Mar 27, 2018

darkelement1987 commented Mar 27, 2018 • edited

Ditto-IV100 commented Mar 27, 2018 • edited

captbunzo commented Mar 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ditto-IV100 commented Mar 26, 2018 •

edited

pogo-excalibur Mar 26, 2018 •

edited

pogo-excalibur Mar 26, 2018 •

edited

Ditto-IV100 Mar 27, 2018 •

edited

darkelement1987 commented Mar 27, 2018 •

edited

Ditto-IV100 commented Mar 27, 2018 •

edited