New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update User-Agent with the most recent version #2548
base: develop
Are you sure you want to change the base?
Conversation
Unlikely to be a major issue as this UA is CFNetwork and Darwin versions (which are generally speaking relative to iOS version, and thus not really an issue, as these current UAs were pulled from my own iPhone devices a couple iOS versions ago). Still good to update though. |
The answer is 'a couple iOS versions ago'. Most users update iOS within a week. Nevermind. |
Okay, and? Niantic nor PTC are going to ban someone because they are using older iOS versions. We're talking within the major iOS version (so something like 11.1) here. I'm not speaking of iOS 8 here.\ I don't disagree with the change, otherwise I would have closed the PR. I don't think it's a MAJOR MERGE ASAP change though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked these headers under latest iOS, iPhone X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes on it's own works fine (proxies are still banned).
However it is worth to point out that these changes ONLY changes the user agent of the proxy checks.
The user agent used for actual requests are defined in the pgoapi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR also requires a pgoapi User-Agent update.
Description
User-Agent header is too old and it should be updated
Motivation and Context
This fix possibly helps to prevent detecting a suspicious traffic and a resulting ban of proxies
How Has This Been Tested?
New header is from mitmproxy and a real PokémonGo on iOS
Screenshots (if appropriate):
Types of changes
Checklist: