Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Pokemon downscaling after rarity upscale #2514

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Levonestral
Copy link
Contributor

@Levonestral Levonestral commented Mar 4, 2018

Description

This allows you to choose any number of Pokemon and override their scaling to be "normal" instead of their assigned rarity scale.

Motivation and Context

Certain rarities of Pokemon result in a larger scaled display on the map. Although most of the time this is very helpful, there are some Pokemon that users may still not want to have larger (For example, Wobuffet for my users was not wanted to see larger scaled due to rarity).

RocketMap already allows the override the default size of 2 to make them larger, so this PR simply does the opposite and allows you to override the rarity size and force them back to 2 (normal).

How Has This Been Tested?

Smaller map. 5 instances, 300 accounts.

Screenshots (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@sebastienvercammen sebastienvercammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this review. 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants