New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'is_in_battle' db field and icon on map #2500
base: develop
Are you sure you want to change the base?
Conversation
How long does this data stay in db? I would love to collect data on gym activity. |
It is always just the current state when it was scanned. |
Tagged breaking change to refer to icon/spritesheet generation as a reminder for our devs. |
@michikrug Could you rebase? And thoughts on separating the "gym in battle" functionality from your other PR for image generation? As it stands, we won't be able to merge either PR. Separating them makes merging this PR much easier. |
e88c2d4
to
a2787d4
Compare
@sebastienvercammen Have rebased. Currently, the 'is in battle' mark is completely relying on the dynamic image creating PR. Therefore, it will be hard to separate them. I can try visualizing the battle state differently, so that it does not use the whole image stuff. |
Needs to be rebased |
…, do not cache images with missing parts
22c53f5
to
8422d69
Compare
…, do not cache images with missing parts
@sebastienvercammen rebased and used a simpler way of displaying only the battle state |
So this would make things like triggering Pokealarms like 'Gym Team Valor is under attack' a possibility in the future? |
Description
Adds 'is_in_battle' db field for gyms and display a fighting icon on the map.
Motivation and Context
Show the users which gyms are currently under attack by adding a little icon on top of the gym image.
How Has This Been Tested?
Tested on local instance.
Screenshots (if appropriate):
Types of changes
Checklist: