Gym/Pokestop Scan Scheduler #2498

fosJoddie · 2018-02-18T10:37:44Z

Implements a gym scan scheduler.
Update: now also a pokestop scan scheduler if you're into knowing about lured spots.
Anything mentioning gyms in the description probably also goes for pokestops.

Description

Currently, the "best" way to mass scan gyms for raid alerts is to use hex scan in tandem with a carefully crafter geofence around the gyms involved.

This is very tedious work and might even skip a gym or two if you are experimenting with tiny geofences.

WARNING
Since gyms can be scanned at any speed, this scheduler will most likely not be able to spin pokestops and make fresh accounts level 2. This means you have to prepare accounts by using the levelup tool, or use already shadowbanned 2nd hand accounts.

This scheduler asumes that you have discovered all gyms in your area by using a traditional hex scan or speed scheduler first. Any gyms discovered in the process of scanning, won't be clustered until next restart of the instance.

EDIT: If you made it this far, you enable the scheduler with -scheduler: FortSearch

Introducing
The gym scan scheduler

Finds any gym already in your database
Clusters the gyms to optimize search area
Supports geofencing to narrow down area
uses scan-delay with # of workers to adjust how often all gyms are scanned.
toggle gyms/pokestops with -ng -nk

Motivation and Context

With the current short lifespan of accounts, this scheduler allows for a minimum of accounts to scan for
raids.

How Has This Been Tested?

Running for a week with little to no explosions

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

The-Real-Ketchum-Dev · 2018-02-18T11:31:16Z

I like this option.. Will this have an option in the config sort of like spawn point scan or speed scan?

friscoMad · 2018-02-18T11:40:28Z

Seems ok, my 3 comments:

Spawnpoint cluster maybe can extend this cluster system, to avoid having mostly duplicated code (I know it is not the same as spawnpoint need to check appear/disappear times).
Geofence before clustering, otherwise it will scan gyms outside the fence, it can happen anyway but in a lesser extent if done in this order.
Maybe it is the right time to have a single flag with different values for the scheduler, you can not set several at the same time and some schedulers are defined by strange flags (skip if empty) so it will be a lot clearer if we had -scheduler: speed or -scheduler: hex

fosJoddie · 2018-02-18T13:32:15Z

Yeah I looked at reusing existing cluster code. Can probably just reuse the same code from Spawnpoint Scan.

Gf first is coming.

I did not want to start redoing the logic of how schedulers are selected. That would make this pr a breaking change. I’m not against doing that tho, naturally.

SkOODaT · 2018-02-18T16:05:11Z

thier was a fort only scanning mode PR created allready.... ive been using it to scan stops and gyms for months and its worked fine lol

#1957

i removed the need for dumping but to scan just stops and gyms this works great.... i use it to lure

fosJoddie · 2018-02-18T19:56:23Z

@SkOODaT that PR was closed a long time ago, and used a somewhat different approach. Not sure what lures has to do with scanning gyms. The intent for this PR is to discover raids, and little more.

SkOODaT · 2018-02-18T20:07:35Z

@fosJoddie the other PR was able to do forts in general so gyms for raids or gym data and pokestops for lured pokemon/luring stops for those who have it would be nice if this PR did ALL forts like the other one but just a suggestion

michikrug · 2018-02-18T21:43:47Z

Also running #1957 for a really long time now. It works okay. But I do see a lot of space for improvement. Therefore, I am looking forward to see how this approach develops.

fosJoddie · 2018-02-18T22:31:49Z

@SkOODaT luring stops will never be a part of RM, it's directly interrupting the game economy in a negative way.

Sorry for tagging you wrongly @The-Real-Ketchum-Dev - my bad

The-Real-Ketchum-Dev · 2018-02-18T22:47:34Z

I never assumed anything about lure i was asking about gym scanning

…

On Feb 18, 2018 5:31 PM, "Joddie" ***@***.***> wrote: @The-Real-Ketchum-Dev <https://github.com/the-real-ketchum-dev> luring stops will never be a part of RM, it's directly interrupting the game economy in a negative way. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2498 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aimmc-as8Rc43KJBSD-VlJDTiK2PfAZHks5tWKTcgaJpZM4SJpO2> .

The-Real-Ketchum-Dev · 2018-02-18T22:48:37Z

Sorry only seen the email and cut it off.. All good bud

SkOODaT · 2018-02-18T23:23:09Z

@fosJoddie i never said anything about adding luring to this lmao but fort scanning all forts is beneficial in other ways, such as gathering stop information.....

fosJoddie · 2018-02-19T11:16:18Z

@friscoMad I started reworking the scheduler flags to use the single -scheduler. My only mystery guest is skip-empty which I feel like is a bad name for "hex scan minus the parts with no results".

Code now reuses the clustering from spawnpoint - I'm not sure if it broke anything with spawnpoint scheduler.

Geofencing now happens before clustering

friscoMad · 2018-02-19T11:28:36Z

Not tested but the code seems to be good, thanks for taking the effort to refactor clustering and looking at -scheduler I agree that it should be in a another PR.
Skip-empty could be renamed to hex-noEmpty or something like that, right now that flag it is the worst one as no one identifies that flag with a scheduler and it takes precedence over other scheduler flags.

fosJoddie · 2018-02-19T15:42:24Z

I felt like the extra work to make another pr for -scheduler was not worth it. Can split this into to PR if the scope is now too big.

PR can now scan for pokestops as well as gyms.
PR now has new argument: -scheduler that inputs what scheduler you want to use

TODO:
I have a feeling -bh is not going to be friends with this scheduler

friscoMad · 2018-02-20T10:37:31Z

pogom/utils.py

+    parser.add_argument('-sch', '--scheduler',
+                        help=('Set scan scheduler to use. One of: '
+                              'hex, spawnpoint, speed, gym'),
+                        type=str, default='hex')


Add choices to force validation as -wh-types

--skip-empty is no longer needed

Probably we should also change default to SpeedScan

friscoMad · 2018-02-20T10:42:34Z

pogom/utils.py

            args.scheduler = 'HexSearch'
+        else:


Not needed if choices is added to the add argument.
And maybe the valid values should be the full name of the scheduler, that saves us for this translation code and makes configuration more inline with the docs.

fosJoddie · 2018-02-20T19:10:43Z

Changed argument parser to use real names of scanners.

SpeedScan is now the default - gonna break configs that run without any scheduler flags.

I won't remove skip-empty, since that would be removing a full scheduler that I guess some people might be using. it is named HexSearchSpawnpoint now.

The names of the schedulers could be shortened a whole lot tho, since they are only referenced on Sceduler creation and a few odd places in code. Not sure what best course of action would be

friscoMad · 2018-02-20T19:18:38Z

Umm just saying that we should remove the --skip-empty flag now that we have -scheduler HexSearchSpawnpoint

fosJoddie · 2018-02-21T08:59:38Z

Ohh. Then we are in complete agreement.

The flag is removed. 👌

darkelement1987 · 2018-03-01T15:46:39Z

Is this ready to be merged?

fosJoddie · 2018-03-05T22:40:52Z

@darkelement1987 it's ready to be tested - I just rebased and fixed conflicts

billyjbryant · 2018-03-16T02:45:02Z

@fosJoddie, needs to be rebased again. Once it is I can test it.

fosJoddie · 2018-03-16T09:51:41Z

@billyjbryant thanks for the heads up, it has been rebased back into former glory

Geofence gym coordinates before we cluster them

Move arguments for schedulers into a single parameter "scheduler" Refactor usage of args scheduler checking

Rewrite documentation for command line

Use actual scheduler names as argument

Make a FortSearch scheduler for Gym and Pokestop scanning Move arguments for schedulers into a single parameter "scheduler"

darkelement1987 · 2018-03-30T19:23:51Z

config/config.ini.example

+                                # based on step size.
+#scheduler: HexSearchSpawnpoint # Hex scan with skipping of empty cells.
+                                # Normal hex scan must have been ran at least once.
+


Empty line 62 can be removed.

sebastienvercammen added this to the 4.1.1 milestone Feb 18, 2018

sebastienvercammen added new feature pending changes labels Feb 18, 2018

fosJoddie changed the title ~~[WIP/RFC] Gym Scan Scheduler~~ [beta] Gym Scan Scheduler Feb 19, 2018

fosJoddie changed the title ~~[beta] Gym Scan Scheduler~~ Gym Scan Scheduler Feb 19, 2018

fosJoddie changed the title ~~Gym Scan Scheduler~~ Gym/Pokestop Scan Scheduler Feb 19, 2018

friscoMad reviewed Feb 20, 2018

View reviewed changes

fosJoddie force-pushed the gym-scanner branch from 8b9b857 to e074970 Compare February 20, 2018 19:03

fosJoddie force-pushed the gym-scanner branch from fcf8e59 to e275ad9 Compare March 5, 2018 22:40

sebastienvercammen added the awaiting review label Mar 9, 2018

sebastienvercammen removed the pending changes label Mar 9, 2018

fosJoddie force-pushed the gym-scanner branch from e275ad9 to c2ada9a Compare March 16, 2018 09:51

fosJoddie force-pushed the gym-scanner branch from c2ada9a to 6eef43a Compare March 16, 2018 12:41

fosJoddie added 8 commits March 16, 2018 13:43

Gym Scan Scheduler

709160a

By the power of Duck, reuse existing cluster code

be18fcf

Geofence gym coordinates before we cluster them

make Travis happy. Remove unused import and use proper code style

ea4330b

Make GymSearch a FortSearch that respects -ng and -nk

56abc98

Move arguments for schedulers into a single parameter "scheduler" Refactor usage of args scheduler checking

Make documentation for fort scheduler with some examples

ae10365

Rewrite documentation for command line

Stop startup if beehive optoin is set together with fort scan

ea7d735

Update config.ini example for scheduler argument

a24510f

Use actual scheduler names as argument

Update config example and docs to use SpeedScan default and full names

a392e1d

fosJoddie force-pushed the gym-scanner branch from 6eef43a to f0aff51 Compare March 16, 2018 12:45

Add FortSearch scheduler and move Schedulers into single arg

ea240bb

Make a FortSearch scheduler for Gym and Pokestop scanning Move arguments for schedulers into a single parameter "scheduler"

fosJoddie force-pushed the gym-scanner branch from f0aff51 to ea240bb Compare March 16, 2018 13:24

Add FortSearch scheduler and move Schedulers into single arg

11fbd66

Make a FortSearch scheduler for Gym and Pokestop scanning Move arguments for schedulers into a single parameter "scheduler"

Gundi96 mentioned this pull request Mar 23, 2018

[Stock-RM] Gym/Pokestop Scan Scheduler SenorKarlos/RocketMap#98

Open

6 tasks

darkelement1987 reviewed Mar 30, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gym/Pokestop Scan Scheduler #2498

Gym/Pokestop Scan Scheduler #2498

fosJoddie commented Feb 18, 2018 •

edited

The-Real-Ketchum-Dev commented Feb 18, 2018

friscoMad commented Feb 18, 2018

fosJoddie commented Feb 18, 2018

SkOODaT commented Feb 18, 2018 •

edited

fosJoddie commented Feb 18, 2018

SkOODaT commented Feb 18, 2018

michikrug commented Feb 18, 2018

fosJoddie commented Feb 18, 2018 •

edited

The-Real-Ketchum-Dev commented Feb 18, 2018 via email

The-Real-Ketchum-Dev commented Feb 18, 2018

SkOODaT commented Feb 18, 2018

fosJoddie commented Feb 19, 2018

friscoMad commented Feb 19, 2018

fosJoddie commented Feb 19, 2018

friscoMad Feb 20, 2018

friscoMad Feb 20, 2018

friscoMad Feb 20, 2018

friscoMad Feb 20, 2018

fosJoddie commented Feb 20, 2018

friscoMad commented Feb 20, 2018

fosJoddie commented Feb 21, 2018

darkelement1987 commented Mar 1, 2018

fosJoddie commented Mar 5, 2018

billyjbryant commented Mar 16, 2018

fosJoddie commented Mar 16, 2018

darkelement1987 Mar 30, 2018

Gym/Pokestop Scan Scheduler #2498

Are you sure you want to change the base?

Gym/Pokestop Scan Scheduler #2498

Conversation

fosJoddie commented Feb 18, 2018 • edited

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

The-Real-Ketchum-Dev commented Feb 18, 2018

friscoMad commented Feb 18, 2018

fosJoddie commented Feb 18, 2018

SkOODaT commented Feb 18, 2018 • edited

fosJoddie commented Feb 18, 2018

SkOODaT commented Feb 18, 2018

michikrug commented Feb 18, 2018

fosJoddie commented Feb 18, 2018 • edited

The-Real-Ketchum-Dev commented Feb 18, 2018 via email

The-Real-Ketchum-Dev commented Feb 18, 2018

SkOODaT commented Feb 18, 2018

fosJoddie commented Feb 19, 2018

friscoMad commented Feb 19, 2018

fosJoddie commented Feb 19, 2018

friscoMad Feb 20, 2018

Choose a reason for hiding this comment

friscoMad Feb 20, 2018

Choose a reason for hiding this comment

friscoMad Feb 20, 2018

Choose a reason for hiding this comment

friscoMad Feb 20, 2018

Choose a reason for hiding this comment

fosJoddie commented Feb 20, 2018

friscoMad commented Feb 20, 2018

fosJoddie commented Feb 21, 2018

darkelement1987 commented Mar 1, 2018

fosJoddie commented Mar 5, 2018

billyjbryant commented Mar 16, 2018

fosJoddie commented Mar 16, 2018

darkelement1987 Mar 30, 2018

Choose a reason for hiding this comment

fosJoddie commented Feb 18, 2018 •

edited

SkOODaT commented Feb 18, 2018 •

edited

fosJoddie commented Feb 18, 2018 •

edited