New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RM look nice #2496
Open
michikrug
wants to merge
8
commits into
RocketMap:develop
Choose a base branch
from
michikrug:PR-style
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make RM look nice #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally fine with that. |
Added some screenshots of raids. |
Also added some screenshots of Pokémon label. |
Move pokemon type badge style to css file
Decrease size of form string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a plain cosmetic PR that optimizes display of menu, marker labels and gym sidebar.
It already includes the changes proposed by #2476 and #2488. (Thanks to the authors!)
Motivation and Context
RM looks kinda messy currently.
The style ideas are nice, but poorly applied.
E.g.:
Thus, I optimized a LOT of styles to make RM look nice on desktop and mobile.
How Has This Been Tested?
Own instance.
Screenshots (if appropriate):
Old:
New:
Types of changes
Checklist: