Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RM look nice #2496

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Make RM look nice #2496

wants to merge 8 commits into from

Conversation

michikrug
Copy link
Contributor

@michikrug michikrug commented Feb 16, 2018

Description

This is a plain cosmetic PR that optimizes display of menu, marker labels and gym sidebar.
It already includes the changes proposed by #2476 and #2488. (Thanks to the authors!)

Motivation and Context

RM looks kinda messy currently.
The style ideas are nice, but poorly applied.
E.g.:

  • the labels did not use the same font as the rest of the page
  • inconsistent underlining
  • strange paddings / margins and font sizes
  • bad alignment
  • not the best responsive changes
  • ...

Thus, I optimized a LOT of styles to make RM look nice on desktop and mobile.

How Has This Been Tested?

Own instance.

Screenshots (if appropriate):

Old:
bildschirmfoto 2018-02-16 um 23 58 41

New:
bildschirmfoto 2018-02-17 um 00 04 12

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@sebastienvercammen sebastienvercammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To properly credit authors, pending merge of #2476 and #2488. We don't allow "combo PRs" which merge the work of other PRs that came before it. This PR has more than just the combo, so it can be rebased after those two are merged.

@michikrug
Copy link
Contributor Author

I'm totally fine with that.

@michikrug
Copy link
Contributor Author

Added some screenshots of raids.

@michikrug
Copy link
Contributor Author

Also added some screenshots of Pokémon label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants