Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New Spawn" group to fix issue #2469. #2487

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add "New Spawn" group to fix issue #2469. #2487

wants to merge 5 commits into from

Conversation

BrownSlaughter
Copy link
Contributor

@BrownSlaughter BrownSlaughter commented Feb 9, 2018

There is a current issue of a brand new pokemon spawn and it will not be set a rarity until the dynamic rarity filer is updated.

We could set all new pokemon to ultra rare but for people who dont update rarity often this would mean things as common as pidgey would stay ultra rare until rarity file is next updated.

This way sets all new pokemon as a "New Spawn" and once the rarity file is updated it will be sorted properly. I added "New Spawn" to notify by rarity on the side bar and also included it in scale by rarity.

This will fix Issue #2469

How Has This Been Tested?

Tested on a live map and simulated new spawns to test it

image

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrownSlaughter BrownSlaughter changed the title add new spawn group to fix issue #2470 add new spawn group to fix issue #2469 Feb 9, 2018
@sebastienvercammen sebastienvercammen added this to the 4.1.1 milestone Feb 12, 2018
@sebastienvercammen sebastienvercammen changed the title add new spawn group to fix issue #2469 Add "New Spawn" group to fix issue #2469. Feb 27, 2018
Copy link
Member

@sebastienvercammen sebastienvercammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing update to get_pokemon_rarity in utils.py to return New Spawn for new spawns.
  • updatePokemonRarities is only called once in the JS, so new spawns will stay new spawns until the visitor refreshes the page after a Pokémon has been scanned.
  • 0 entries in DB = no data in rarities file = "New Spawn". But 1 entry isn't enough to define its rarity. (Arguably a problem that fixes itself with dynamic rarity and calling updatePokemonRarities on a timer.)

@darkelement1987
Copy link
Contributor

Is webhook support possible for 'New spawns' ?

@darkelement1987
Copy link
Contributor

darkelement1987 commented Mar 16, 2018

Did you consider adding the 'New spawns' to the rarity exclusion filter? Also does this work with 'Hide Unnotified'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic rarity does not handle extremely rare species that didn't spawn in the time window
3 participants