New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "New Spawn" group to fix issue #2469. #2487
Open
BrownSlaughter
wants to merge
5
commits into
RocketMap:develop
Choose a base branch
from
BrownSlaughter:patch-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrownSlaughter
changed the title
add new spawn group to fix issue #2470
add new spawn group to fix issue #2469
Feb 9, 2018
sebastienvercammen
changed the title
add new spawn group to fix issue #2469
Add "New Spawn" group to fix issue #2469.
Feb 27, 2018
sebastienvercammen
requested changes
Feb 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Missing update to
get_pokemon_rarity
inutils.py
to returnNew Spawn
for new spawns. updatePokemonRarities
is only called once in the JS, so new spawns will stay new spawns until the visitor refreshes the page after a Pokémon has been scanned.- 0 entries in DB = no data in rarities file = "New Spawn". But 1 entry isn't enough to define its rarity. (Arguably a problem that fixes itself with dynamic rarity and calling
updatePokemonRarities
on a timer.)
Is webhook support possible for 'New spawns' ? |
Did you consider adding the 'New spawns' to the rarity exclusion filter? Also does this work with 'Hide Unnotified'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a current issue of a brand new pokemon spawn and it will not be set a rarity until the dynamic rarity filer is updated.
We could set all new pokemon to ultra rare but for people who dont update rarity often this would mean things as common as pidgey would stay ultra rare until rarity file is next updated.
This way sets all new pokemon as a "New Spawn" and once the rarity file is updated it will be sorted properly. I added "New Spawn" to notify by rarity on the side bar and also included it in scale by rarity.
This will fix Issue #2469
How Has This Been Tested?
Tested on a live map and simulated new spawns to test it
Types of changes
Checklist: