Add weather layer on main page #2420

codename-art · 2018-01-03T00:13:34Z

Description

Adds visualization of weather to the main page. There are three display options:

weather icons for the present weather,
mesh of s2cells (size 10), each cell have the same weather,
weather alers: add color for cells with alert.

Motivation and Context

Weather conditions strongly affect the game mechanics. Visualizing the weather on the map will help, for example, in finding raids with weather boosts. Also weather updates can help in finding of obsolete encounter info.

How Has This Been Tested?

On my own map

Screenshots (if appropriate):

Weather icons

s2Cells

different weather allerts

Weather info and wind direction on top bar if screen covers more then a half of s2cell

Weather report for all cells in browser (/weather)

Weather report for all cells in console

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

Great participation in the development took @SkOODaT

Alderon86 · 2018-01-03T00:21:29Z

Awesome work <3

ghost · 2018-01-03T00:34:38Z

The S2 cells are working as intended, but I'm getting undefined undefined on the top-bar and no weather icons on the map itself.

ghost · 2018-01-03T00:48:08Z

^ It's starting to populate the icons now as areas are being rescanned but shows what's in the above screenshot until I zoom in.

So the behavior i'm getting is:

Zoomed out really far - No weather icons in the top-bar. Assuming that's intended.

Zoomed into to fit 2 s2 cells in the viewport - top-bar displays: undefined undefined

Zoomed into to fit most of 1 s2 cell in the viewport - top-bar displays weather status, but the words and icons need a little padding between them:

This is in Chrome, by the way.

Alderon86 · 2018-01-03T00:58:06Z

@blakewenloe weather on top bar only shows up if a single s2cell is on the screen otherwise it wont show any, theres weather Alert for that. undefined as u said shouldnt pop up at anytime, you are right.

ghost · 2018-01-03T01:02:10Z

I also think it would be a good idea to display what type of "extreme" weather is in the cells versus just the extreme icon. Maybe the weather icons with ! marker on them or just with the extreme weather icon color? Because the extreme weather icon isn't really informative in itself. This is an awesome PR and i'm excited to use it!

codename-art · 2018-01-03T01:30:37Z

@blakewenloe There is a red alert for extreme severity too. When a warning appears, weather bonuses stop working.

ghost · 2018-01-03T01:36:07Z

@codename-art I thought they patched that to where the user just has to tap the "I'm safe" button and weather bonuses still apply? I may be wrong, but I'm seeing that in my personal game (we have extreme weather alert right now) at least.

codename-art · 2018-01-03T01:51:12Z

@blakewenloe maybe I have wrong or outdated information. I'll figure out how to do it right.

ghost · 2018-01-03T02:10:53Z

@codename-art this is an example of the prompts we go through in extreme weather if that helps.

ClarkyKent · 2018-01-03T11:53:19Z

pogom/models.py

@@ -2333,6 +2459,8 @@ def parse_map(args, map_dict, scan_coords, scan_location, db_update_queue,
        db_update_queue.put((ScanSpawnPoint, scan_spawn_points))
        if sightings:
            db_update_queue.put((SpawnpointDetectionData, sightings))
+    if weather:
+        db_update_queue.put((Weather, weather))


We know that weather updates every hour. So may be we can update db every hour or so.

i set it up to update continuously because of severity alerts, i have also added everything needed for this to work with poke alarm

I added check for ignoring updates in same hour.

ClarkyKent · 2018-01-03T11:58:26Z

static/js/weather.js

+        imageUrl = imageUrl.replace('weather_', 'weather_light_')
+    }
+    return imageUrl
+}


I think adding a default "unknown weather" icon is necessary as sometimes in-game weather does not function. It will fix undefined pic/weather error.

ClarkyKent · 2018-01-03T13:30:27Z

static/js/weather.js

+        position: item.center,
+        icon: image
+    })
+}


Need to resize the weather icons while zooming out. If someone have bigger map. Weather icons can get out of s2cell and overlap.

SkOODaT · 2018-01-03T16:53:37Z

awesome it got submitted for default RM, this is my backend work and A.R.Ts front end work :)

SkOODaT · 2018-01-03T16:57:58Z

@codename-art ive made some more changes to my copy since weather alerts are passable now you might want to pull them
~ i removed the alert icons off the tiles and moved the alert icon in the top to its own space (since we can click through now)
~ Webhooks have been added
~ If someone wants to make a PR for pokealarm from my git feel free im not a great git user yet, everything is there needed for weather alerts and changes ~ Unfortunately A.R.T Doesnt use PA (why no PR yet :))
https://imgur.com/a/GXJMj

peterbaumert · 2018-01-03T17:41:56Z

There is a lot of evidence that weather is based on Level 11 cells. I won’t say that this is 100% certain but at least i would make the cell level configurable so people can decide themselves.

pogo-excalibur · 2018-01-03T19:49:55Z

@peterbaumert From inspecting the data coming back from API requests we have concluded that weather is based on strictly level 10 cells.

If this changes we can consider making the cells dynamic, but for various reasons relating to Niantic's approach for pulling data this seems unlikely.

peterbaumert · 2018-01-03T20:53:24Z

@pogo-excalibur ok if api data proofs it, it’s fine with me. I will crosscheck once released with my two spots where weather changes ingame and which are only level 11 borders.

sirlindqvist · 2018-01-03T23:50:45Z

Please remove ingame icons since they can’t be distributed in this pr

SkOODaT · 2018-01-04T01:00:36Z

yes they will half to be removed for public ops lol

SkOODaT · 2018-01-04T01:01:49Z

@codename-art https://www.hongkiat.com/blog/free-weather-iconsets/

codename-art · 2018-01-04T11:12:34Z

@sirlindqvist i used this icons for this PR http://adamwhitcroft.com/climacons/ and https://commons.wikimedia.org/wiki/File:Exclamation_Circle_Red.svg
@peterbaumert weather info passed from niantic server with s2cell_id, level of cell can be calculated from this id. The only problem is that this information is not used for drawing lines, that would be able to draw them without scanning. Nevertheless, when displaying icons and warnings, the coordinates from the niantic are used. In the case of cell-level changes will be noticeable differences with lines.

sebastienvercammen · 2018-01-06T14:32:14Z

@codename-art Think you can fix the Travis issues?

codename-art · 2018-01-09T16:44:32Z

finally figured out the flake8 warnings. Idea automatically performed the formatting of the modified code before commit and canceled my changes

michikrug · 2018-01-11T21:01:06Z

pogom/app.py

+            lines += td(WeatherAlert.Severity.Name(s['severity']))
+            lines += td(s['warn_weather'])
+            lines += td(s['last_updated'])
+            lines += td(pgoapi.protos.pogoprotos.networking.responses


shouldn't that be:

pgoapi.protos.pogoprotos.networking.responses.get_map_objects_response_pb2

to be honest im not sure what art did here, i have it as
lines += td(GetMapObjectsResponse.TimeOfDay.Name(s['world_time']))
This doesn't need to be included ~ def get_weather(self, page=1): .......before art did the nice frontend for weather i just set this up as a temp status page to be able to see the info from a browser, its technically not needed anymore, i think art just merged ALL my changes lol

Well, some imports were refactored and thus the access to the protos was changed.
But here something got lost, which leads to an exception. :)

I kinda like the little status page. It is ugly and even missing basic html tags, but it works. xD

Rework this page with template. Looks the same, but propper html tags and custom.js / custom.css acceptable.

michikrug · 2018-03-14T09:44:43Z

static/js/weather.js

+    $.each(mapData.weather, (i, item) => {
+        if (item.hasOwnProperty('marker') && item.marker) {
+            item.marker.setIcon(createMarkerIcon(item.marker.icon.url))
+            item.marker.setMap(map)


I don't think you should call setMap again

@michikrug You're right, it might not affect anything as we only update the icon. That being said, the old icon can still be drawn on the map if the GMaps API doesn't remove it from the map when we update the marker.

In other code for removal, we use

old.setMap(null) new.setMap(map)

Thoughts? Have you experimented with GMaps' redraws? Did you test your code changes, and did they actually fix it?

I think when you call setIcon the marker icon is just replaced. There is no need to remove the "old" one.
I use the code in my fork and faced no issues so far.

The removal from the map is only necessary if we want to completely remove or replace the whole marker.

@michikrug That's what I assumed, but then these code updates haven't changed the behavior of the drawing or updating, so the overlap issue should persist?

No. Before we were calling the setIcon and setMap on every map scale event for every added marker, which could lead to again adding "old" markers to the map.
The scale event listener for old markers was never removed.

@michikrug You're absolutely correct. 👍 I forgot that the events were being added on each marker (wow...).

fosJoddie · 2018-03-14T10:34:11Z

pogom/app.py

@@ -433,6 +501,19 @@ def raw_data(self):
                    d['main_workers'] = MainWorker.get_all()
                    d['workers'] = WorkerStatus.get_all()

+                if (request.args.get('weather', 'false') == 'true'


Move all the weather request handles above the if request.args.get('status', 'false') == 'true': above and fix indentation (it's currently inside the if for status page)

pogo-excalibur · 2018-03-14T15:02:11Z

docs/extras/webhooks.md

+1. Possible weather conditions:
+
+| Status | Description                                |
+| ------ | ------------------------------------------ |


You should probably include option 0: No weather

pogo-excalibur · 2018-03-14T15:05:16Z

pogom/models.py

+    gameplay_weather = SmallIntegerField(null=True, index=True, default=0)
+    severity = SmallIntegerField(null=True, index=True, default=0)
+    warn_weather = SmallIntegerField(null=True, index=True, default=0)
+    world_time = SmallIntegerField(null=True, index=True, default=0)


Why SmallIntegerField rather than DateTimeField?

Scrap this, I've remembered the relevant proto: It's an enum value representing night/day, not actually a time.

pogo-excalibur · 2018-03-14T15:08:04Z

pogom/models.py

+            now = datetime.now()
+            weather_last_updated = status['weather_last_updated'].get(
+                    s2_cell_id, datetime.utcfromtimestamp(1)
+                )


Indentation.

pogo-excalibur · 2018-03-14T15:09:23Z

pogom/models.py


-    del map_dict['responses']['GET_MAP_OBJECTS']
+            # Convert cell to lat, lng.
+            cell_id = s2sphere.CellId(long(s2_cell_id))


Why is the long() here necessary?

pogo-excalibur · 2018-03-14T15:10:22Z

pogom/models.py

+
+        # Hourly weather update (on the hour).
+        if display_weather:
+            gameplayweather = gameplay_weather.gameplay_condition


gameplayweather => weather_condition

(Or something similar)

pogo-excalibur · 2018-03-14T15:15:15Z

pogom/search.py

        # Print the status_text for the current screen.
        status_text.append((
            'Page {}/{}. Page number to switch pages. F to show on hold ' +
-            'accounts. H to show hash status. <ENTER> alone to switch ' +
+            'accounts. H to show hash status. W to show weather status.' +


Standardise where the spaces are:

'accounts. H to show hash status. W to show weather status. ' + '<ENTER> alone to switch ' +

pogo-excalibur · 2018-03-14T15:17:32Z

pogom/utils.py

@@ -416,6 +420,11 @@ def get_args():
                             'after last valid scan. '
                             'Default: 0, 0 to disable.'),
                       type=int, default=0)
+    group.add_argument('-DCs2', '--db-cleanup-s2-weather',


I'm not sure that the s2 prefix is necessary here.

I'd prefer -DCwe over -DCs2.

pogo-excalibur · 2018-03-14T15:18:53Z

pogom/utils.py

+def degrees_to_cardinal(d):
+    dirs = ["N", "NNE", "NE", "ENE", "E", "ESE", "SE", "SSE",
+            "S", "SSW", "SW", "WSW", "W", "WNW", "NW", "NNW"]
+    ix = int((d + 11.25)/22.5 - 0.02)


Spaces and brackets (check I've put them in the right place): int(((d + 11.25) / 22.5) - 0.02)

pogo-excalibur · 2018-03-14T15:21:11Z

pogom/weather.py

+    return db_weathers
+
+
+# Workaround due a bug in POGOprotos.


Including details of the bug would be useful.

It's a comment from the original author, who is MIA. I assume this might no longer be an issue, but if it's not an issue (and it never overflows) then it'll always follow the else branch. To be on the safe side, we'll keep it as is.

pogo-excalibur · 2018-03-14T16:50:44Z

pogom/app.py

+        ]
+
+        max_weather_per_page = 25
+        max_page = int(math.ceil(len(db_weather)/float(max_weather_per_page)))


Spaces: int(math.ceil(len(db_weather) / float(max_weather_per_page)))

pogo-excalibur · 2018-03-14T17:02:26Z

static/js/weather.js

+ * @param item
+ * @returns {*}
+ */
+function getalertImageUrl(item) {


getalertImageUrl => getAlertImageUrl

pogo-excalibur · 2018-03-14T17:02:45Z

static/js/weather.js

+ * @returns {*}
+ */
+function getalertImageUrl(item) {
+    var alertimageUrl


alertimageUrl => alertImageUrl

pogo-excalibur · 2018-03-14T17:03:33Z

static/js/weather.js

+        }
+    })
+}
+


~~Remove the extra newline.~~

Standardise the newlines - some breaks have one and some have two.

tomballgithub · 2018-03-14T17:07:16Z

I am repeating some feedback from above that may have been lost. This is from many users on my map providing feedback. I think these should be straightforward to implement and make a lot of sense

's2cells' option needs to be renamed for clarity. 'Weather cells'? or 'Weather boundaries'?
Tint each S2 cell a color according to its current condition. This is needed because you can't see weather icon when zoomed in
'Weather alerts' selection is not clear. It could be understood as alerts for when weather is going to change. Add 'extreme' in there since this option is to 'Show Extreme Weather'
Time zone of 'last scanned' is not correct on /weather page
Make clicking the weather in the title bar go to /weather page. There's not other way to get there besides typing the link and no one will know to do that

I need to go retest if any of this has been addressed. It's not obvious from commits above.

tomballgithub · 2018-03-14T17:09:54Z

I personally think the weather in the top bar is confusing. I think the most intuitive use would be to show current weather condition at your location. But it is actually showing the weather of where you have moved to, which is already being shown by an icon on the map or color coding (if suggestion above is taken) so this seems redundant and not intuitive.

tomballgithub · 2018-03-14T21:22:33Z

I see in the .md file that the time is listed as 'world time'. As I mentioned above, that is not particularly useful for most users and the time should be localized like everywhere else (or most everywhere) in RM.

pogo-excalibur · 2018-03-14T21:25:53Z

world_time in this case is an enum: { 'Day', 'Night' }

billyjbryant · 2018-03-14T21:46:43Z

Based on conversation in Reviewers, we should set a limit to how far out the map can be zoomed before we stop attempting to draw the cells on the map. This fixes potentially performance impacting issue where the map attempts to generate the cell boundaries for whatever portion of the map is visible.

The-Real-Ketchum-Dev · 2018-03-15T13:10:03Z

As far as i can tell weather is only shown in the cells that are scanned though unless i am reading this wrong.. No matter the zoom on my setup anyway only the scanned area shows any weather activity

billyjbryant · 2018-03-15T14:58:09Z

but all cells, despite whether they contain information, are drawn on the map, which takes time to calculate the boundaries of each cell and display it.

…

On Thu, Mar 15, 2018 at 9:10 AM, TᴀͪsͤʜᴋᴇᴛᴄʜͬᴜͤᴍͣL ***@***.*** > wrote: As far as i can tell weather is only shown in the cells that are scanned though unless i am reading this wrong.. No matter the zoom on my setup anyway only the scanned area shows any weather activity — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2420 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC37vVKf5pMkibtJGw755wYLJb0RDlSXks5temg0gaJpZM4RROYp> .

-- *Billy J Bryant* *Certified IT Professional* billy@billyjbryant.com www.billyjbryant.com

Alderon86

Couldnt reproduce the duplicated icon bug after latest changes. also i think the ideas in the discussion should be noticed and adressed later with seperate prs.

ClarkyKent

Apart from zooming limit for S2Cell, everything is fine.

sebastienvercammen added awaiting review important new feature labels Jan 3, 2018

sebastienvercammen added this to the 4.1.1 milestone Jan 3, 2018

ClarkyKent reviewed Jan 3, 2018

View reviewed changes

sebastienvercammen added pending changes and removed awaiting review labels Jan 6, 2018

michikrug suggested changes Jan 11, 2018

View reviewed changes

Requested changes.

2451d6f

michikrug reviewed Mar 14, 2018

View reviewed changes

Remove unnecessary setMap.

12533d5

fosJoddie suggested changes Mar 14, 2018

View reviewed changes

Fix rebase issue.

1cc5442

pogo-excalibur reviewed Mar 14, 2018

View reviewed changes

sebastienvercammen force-pushed the vanilla-weather-overlay branch from 115aa2d to f1d51c4 Compare March 14, 2018 20:35

Requested changes.

a3c2d45

sebastienvercammen force-pushed the vanilla-weather-overlay branch from f1d51c4 to a3c2d45 Compare March 14, 2018 20:39

Alderon86 approved these changes Mar 18, 2018

View reviewed changes

ClarkyKent approved these changes Mar 19, 2018

View reviewed changes

Add weather layer on main page #2420

Are you sure you want to change the base?

Add weather layer on main page #2420

Conversation

codename-art commented Jan 3, 2018 • edited

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Alderon86 commented Jan 3, 2018

ghost commented Jan 3, 2018

ghost commented Jan 3, 2018

Alderon86 commented Jan 3, 2018

ghost commented Jan 3, 2018

codename-art commented Jan 3, 2018

ghost commented Jan 3, 2018 • edited by ghost

codename-art commented Jan 3, 2018

ghost commented Jan 3, 2018 • edited by ghost

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClarkyKent Jan 3, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkOODaT commented Jan 3, 2018

SkOODaT commented Jan 3, 2018 • edited

peterbaumert commented Jan 3, 2018

pogo-excalibur commented Jan 3, 2018 • edited

peterbaumert commented Jan 3, 2018

sirlindqvist commented Jan 3, 2018

SkOODaT commented Jan 4, 2018

SkOODaT commented Jan 4, 2018

codename-art commented Jan 4, 2018

sebastienvercammen commented Jan 6, 2018

codename-art commented Jan 9, 2018

Choose a reason for hiding this comment

SkOODaT Jan 11, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastienvercammen Mar 14, 2018 • edited

Choose a reason for hiding this comment

michikrug Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michikrug Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pogo-excalibur Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pogo-excalibur Mar 14, 2018 • edited

Choose a reason for hiding this comment

tomballgithub commented Mar 14, 2018 • edited

tomballgithub commented Mar 14, 2018

tomballgithub commented Mar 14, 2018

pogo-excalibur commented Mar 14, 2018

billyjbryant commented Mar 14, 2018

The-Real-Ketchum-Dev commented Mar 15, 2018

billyjbryant commented Mar 15, 2018 via email

Alderon86 left a comment

Choose a reason for hiding this comment

ClarkyKent left a comment

Choose a reason for hiding this comment

codename-art commented Jan 3, 2018 •

edited

ghost commented Jan 3, 2018 •

edited by ghost

ghost commented Jan 3, 2018 •

edited by ghost

ClarkyKent Jan 3, 2018 •

edited

SkOODaT commented Jan 3, 2018 •

edited

pogo-excalibur commented Jan 3, 2018 •

edited

SkOODaT Jan 11, 2018 •

edited

sebastienvercammen Mar 14, 2018 •

edited

michikrug Mar 14, 2018 •

edited

michikrug Mar 14, 2018 •

edited

pogo-excalibur Mar 14, 2018 •

edited

pogo-excalibur Mar 14, 2018 •

edited

tomballgithub commented Mar 14, 2018 •

edited