Add proxy usage option, take 2 #2302
Conversation
| parser.add_argument('-pxu', '--proxy-usage', | ||
| help=('Select which connections use proxy ' + | ||
| '(all/ptc/niantic).'), | ||
| type=str, default='all') |
There was a problem hiding this comment.
Looking at the code I think that using a repeated value like wh-types it is better (also add valid values) that way the ifs would be if 'ptc' in args.proxy_usage instead of ìf args.proxy_usage != 'niantic'` also it is forward compatibe if in there future more proxy controls are needed (wno knows).
The problem is that I think you can not set the default value to both, but we can do that in code, set default to None and if there are no values defined then just add all of them.
There was a problem hiding this comment.
In fact I chose that approach because I couldn't find a way to set default values to none in a repeated value. This way behaves the same as proxy rotation variable, even if you spell it wrong the default behaviour is the current one.
|
@AEtHeLsYn is this PR still active? |
Description
With this PR we can choose if we want to use the proxies for all connecions, only for ptc login or only for niantic connections
Motivation and Context
We can use proxies only for ptc login or for niantic sessions if we have an IP banned for one of them, not both.
How Has This Been Tested?
Local map
Screenshots (if appropriate):
Types of changes
Checklist: