Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EX raid support #2298

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

EX raid support #2298

wants to merge 4 commits into from

Conversation

ibuckshot5
Copy link
Contributor

With Mewtwo coming to EX raids soon, support should be needed.

Description

Added the ability for RocketMap to tell normal raids apart from EX raids.

Motivation and Context

Mewtwo's coming out soon.

How Has This Been Tested?

Local installation

I haven't actually seen an EX raid though

Screenshots (if appropriate):

alt text

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@friscoMad
Copy link
Contributor

Has this been tested with real scan data, I am not sure that ex raids will be shown to not invited players.

Also you need to fix travis and do a proper DB migration to add the new column

@pogo-excalibur
Copy link
Contributor

pogo-excalibur commented Sep 16, 2017

As people who can't participate in the raid get this message:
znmoxj8qh2zgzhdclgekbuvcazfxu3dxqff5jwloe3k

(from TSR: https://www.reddit.com/r/TheSilphRoad/comments/70d5sh/ex_raids_from_wave_2_now_display_gym_closure/)

There must be some way of detecting an EX raid.

But it looks like non-participants can't see the egg (the message above only appears once the raid actually starts), so how useful this will be is an open question.

Copy link
Contributor

@sirlindqvist sirlindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use css classes for FontAwesone padlock and bold text as we do for all the other styles.

@SkOODaT
Copy link

SkOODaT commented Sep 17, 2017

exclusive raids are being "tested" so yes only invited players will be able to see it right now but when they go global im sure the "'exclusive': raid_info.is_exclusive" will still be used so i can see this possibly being useful some point... when they do activate globally tho im sure current setups will still post them as long as the assets are there and enabled, i added the basic mewtwo stuff a few weeks ago to my copy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants