New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable asset and item templates requests on login. #2243
base: develop
Are you sure you want to change the base?
Conversation
we should store them in the database instead of disabling it, so other workers can reuse the values. |
It would be a waste of db operations, I've thought about saving them in a |
Adding comments from Discord:
The requests should be complete, but only done once where possible. |
I am storing the timestamps for each account in a JSON file on the disk so that the accounts only do the requests if actually something was changed. Thus, fresh accounts do it once and if nothing changes never again and additionally, it also survives restarts of the instance. |
ccb3090
to
61d9c99
Compare
61d9c99
to
723dea9
Compare
723dea9
to
bd1cfc7
Compare
bd1cfc7
to
eb9f107
Compare
ede3e97
to
a700fd2
Compare
9ae1c59
to
8c825bc
Compare
61b870a
to
81e7ccc
Compare
31af424
to
4119a71
Compare
4119a71
to
97cad70
Compare
…gin phase. This can save a lot of requests - up to 25 requests - per new unique account login.
97cad70
to
38138e6
Compare
Description
It defeats a bit the purpose of having them in the first place but when you're running a tight on RPM it can potentially save you from a bottleneck.
Motivation and Context
Run instance with
-nar
,--no-asset-requests
to disable these requests.How Has This Been Tested?
Local instance.
Screenshots (if appropriate):
Types of changes
Checklist: