Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Add "Missed" to worker status stats. #2063

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

neskk
Copy link
Contributor

@neskk neskk commented May 24, 2017

This PR is for debug purposes and it updates database schema version - just one tiny modification to workerstatus table - if you want to reverse the update, drop the table, revert schema version to 19 and you're good.

It adds "Missed" column to status page and status printer (console) to track missed spawnpoints. The idea came from @aRengo and I decided to do a branch isolating this change.

Description

Adds a new statistic to WorkerStatus: missed - that tracks whenever a spawnpoint is missed by the worker when map request is parsed. This can happen because account is "shadowed/blind" or if spawnpoint data is old and outdated.

Motivation and Context

Get more information on "shadowed/blind" accounts and how to identify them.

How Has This Been Tested?

Tested in local environment and server with several instances.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SiteEffect
Copy link
Contributor

Good one :-)

@bbdoc
Copy link

bbdoc commented May 26, 2017

What about adding a message to log when a LVL 30 account is sent for an encounter but doesn't see the pokemon it should encounter ? That would mean a low level account could see it but your lvl 30 couldn't see it, so it's shadowbanned... Would make it very easy to identify shadowbans at least for high level accounts. Even better with some increment "L30 account xxx could not encounter a pokemon for xx times in a row".

Would be even better to add this info in workerstatus table but I don't think Lvl 30 accounts are in there...

Commenting on this PR as the objective is the same, help identify "blind" accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants