Rarity Exclusion first displays pokemon, then removes them

[wfcook]

Expected Behavior

When the "Exclude Rarity" option is used, e.g. to exclude pokemon that are "Uncommon and below", those pokemon should never be drawn.

Current Behavior

RocketMap first displays all pokemon and then removes the excluded rarities en masse. This makes panning the map awkward and slow.

In contrast, when individual pokemon are excluded Via the "Hide Pokemon" feature, they are never drawn.

Possible Solution

Move the check for rarity exclusion to the same location as the check for individual exclusion?

Steps to Reproduce (for bugs)

Context

The "exclude by rarity" feature is potentially much more useful now with the new dynamic rarity, but currently runs slowly and awkwardly.

Your Environment

• Version used: latest
• Python 2.7
• Windows 10

[sebastienvercammen]

@wfcook

updateMap: https://github.com/RocketMap/RocketMap/blob/develop/static/js/map.js#L1914

• Loads data, then
• calls processPokemons
• which calls processPokemonChunked
• which calls processPokemon
• which finds that the Pokémon is excluded by rarity and so it returns no markers for the Pokémon.

Maybe you can include a screen recording of the behavior issue you're having?

[wfcook]

Will work on it

[wfcook]

https://www.youtube.com/watch?v=IplFGdpOOQ8

Video quality is terrible, but you'll see what I mean

[wfcook]

@sebastienvercammen see video above

[BrownSlaughter]

I can confirm it does draw the pokemon then removes them afterwards, when I load the map it draws everything then removes common

[trunksbomb]

The problem is that excludedPokemonByRarity is never sent to the server during the request for new Pokemon. So what happens is the server returns the entire list of available Pokemon (minus the ones you have explicitly excluded) to the client, then the client parses all the received Pokemon (puts them on the map) then filters them out, which causes the blinking.

I'll submit a PR to fix this behavior.