Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GenericModal with no ask again checkbox missing margin #32414

Merged
merged 3 commits into from May 13, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 10, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-430

Copy link
Contributor

dionisio-bot bot commented May 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 5de87f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.9 milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.74%. Comparing base (3b06229) to head (5de87f3).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32414      +/-   ##
===========================================
+ Coverage    55.56%   55.74%   +0.18%     
===========================================
  Files         2400     2406       +6     
  Lines        52814    52983     +169     
  Branches     10855    10885      +30     
===========================================
+ Hits         29346    29538     +192     
+ Misses       20865    20835      -30     
- Partials      2603     2610       +7     
Flag Coverage Δ
e2e 54.87% <0.00%> (-0.05%) ⬇️
e2e-api 41.05% <ø> (+0.94%) ⬆️
unit 73.25% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review May 13, 2024 19:19
@dougfabris dougfabris requested a review from a team as a code owner May 13, 2024 19:19
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label May 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 13, 2024
@kodiakhq kodiakhq bot merged commit ff35376 into develop May 13, 2024
38 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/withDoNotAskAgain-spacing branch May 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants