fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow

[matheusbsilva137]

Proposed changes (including videos or screenshots)

• Correctly check for the Accounts_AllowPasswordChangeForOAuthUsers in the users.forgotPassword endpoint.

Issue(s)

Steps to test or reproduce

1. Go to Settings > Accounts > Allow Password Change for OAuth Users and disable this setting.
2. Create a user via LDAP or OAuth;
3. Log out and use the "Forgot your password?" option to reset the password of the user that has just been created;
   Current behavior: the reset password e-mail is sent (even to LDAP/OAuth users that didn't have a password before);
   Expected behavior: the reset password e-mail should not be sent.

Further comments

CORE-439

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 1df6f70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.86%. Comparing base (61e31aa) to head (1df6f70).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32398      +/-   ##
===========================================
- Coverage    55.86%   55.86%   -0.01%     
===========================================
  Files         2432     2432              
  Lines        53480    53480              
  Branches     10993    10993              
===========================================
- Hits         29877    29874       -3     
- Misses       20965    20966       +1     
- Partials      2638     2640       +2     

Flag	Coverage Δ
e2e	55.19% <ø> (-0.02%)	⬇️
unit	72.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[dougfabris]

Approving it on behalf of frontend team!