New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Integration entity out of db watcher #32378
refactor: Integration entity out of db watcher #32378
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32378 +/- ##
===========================================
- Coverage 55.59% 55.55% -0.04%
===========================================
Files 2408 2405 -3
Lines 52997 52982 -15
Branches 10894 10893 -1
===========================================
- Hits 29465 29436 -29
- Misses 20918 20943 +25
+ Partials 2614 2603 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
747a811
to
0976c47
Compare
apps/meteor/app/channel-settings/server/functions/saveRoomName.ts
Outdated
Show resolved
Hide resolved
1dd8472
to
1c53d12
Compare
1c53d12
to
f4d1e77
Compare
As per the updates mentioned in PROJ-7 SCA-4 and ADR #74, this pull request focuses on relocating Integration entity out of DB Watcher service.
Quick context to public readers
In essence, this modification empowers RocketChat's app to directly call listeners through the
api.broadcast
global function, eliminating the reliance on MongoDB Change Stream data propagationWhy is this beneficial? It provides better control over notifying users by enabling more precise use-case management. Unlike Change Streams, which notify every action on Mongo's documents and sometimes might result in unnecessary duplicate notifications. Moreover, it contributes to the future removal of the DB Watcher deployment, thereby optimizing resource utilization.
Proposed changes
Key changes include:
dbWatchersDisabled
flag.watch.integrations
listener event, subject to thedbWatchersDisabled
flag.Updated use cases.
users.delete
saveRoomName
on channel-settings packagedeleteIncomingIntegration
integrations.remove
updateIncomingIntegration
integrations.update
integrations.create
executeTriggerUrl
onRocketChatIntegrationHandler
fileSteps to test or reproduce
DISABLE_DB_WATCHERS
flag set to true.POST
request to above given endpoints available on updated use cases.Further comments
To maintain consistency and avoid potential regressions, event names and signatures have been kept unchanged on both the client and app sides. This decision streamlines efforts and mitigates the risk of unintended consequences.
Integration model WBS. Used to guide changes discovery.
🔄 Work in progress
✅ Done
➖ Not applicable