New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: LoginServiceConfiguration entity out of DB Watcher #32373
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32373 +/- ##
===========================================
- Coverage 55.81% 55.80% -0.01%
===========================================
Files 2413 2413
Lines 53160 53180 +20
Branches 10925 10932 +7
===========================================
+ Hits 29669 29675 +6
- Misses 20871 20892 +21
+ Partials 2620 2613 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
5a56f2b
to
d207a7b
Compare
…tion based on dbWatchersDisabled
3c076e4
to
5b95b26
Compare
715e34f
to
b1287dc
Compare
…:RocketChat/Rocket.Chat into refactor/login-service-out-of-db-watcher
As per the updates mentioned in PROJ-7 SCA-4 and ADR #74, this pull request focuses on relocating LoginServiceConfiguration entity out of DB Watcher service.
Quick context to public readers
In essence, this modification empowers RocketChat's app to directly call listeners through the
api.broadcast
global function, eliminating the reliance on MongoDB Change Stream data propagationWhy is this beneficial? It provides better control over notifying users by enabling more precise use-case management. Unlike Change Streams, which notify every action on Mongo's documents and sometimes might result in unnecessary duplicate notifications. Moreover, it contributes to the future removal of the DB Watcher deployment, thereby optimizing resource utilization.
Proposed changes
Key changes include:
dbWatchersDisabled
flag.watch.loginServiceConfiguration
listener event, subject to thedbWatchersDisabled
flag.Updated use cases.
refreshOAuthService
configureLoginServices
>configureOAuth
Steps to test or reproduce
DISABLE_DB_WATCHERS
flag set to true.POST
request to above given endpoints available on updated use cases or enable SAML on the application.Further comments
To maintain consistency and avoid potential regressions, event names and signatures have been kept unchanged on both the client and app sides. This decision streamlines efforts and mitigates the risk of unintended consequences.
LoginServiceConfiguration model WBS. Used to guide changes discovery.
🔄 Work in progress
✅ Done
➖ Not applicable