fix: add oplog metrics to stream-hub #32366
Open
+65
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d896b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32366 +/- ##
===========================================
+ Coverage 55.53% 55.57% +0.04%
===========================================
Files 2401 2401
Lines 52855 52856 +1
Branches 10854 10854
===========================================
+ Hits 29353 29376 +23
+ Misses 20898 20878 -20
+ Partials 2604 2602 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
implement-oplog-metrics-on-streamhub
branch
2 times, most recently
from
4adc673
to
b50443b
Compare
sampaiodiego
commented
May 7, 2024
| return super.on('doc', callback); | ||
| } | ||
|
|
||
| onCollection<T>(collection: string, callback: (event: RealTimeData<T>) => void): this { |
There was a problem hiding this comment.
renamed on<T> to onCollection<T> so we don't overwrite EventEmitter.on but still got typing
sampaiodiego
commented
May 7, 2024
KevLehman
reviewed
May 7, 2024
sampaiodiego
force-pushed
the
implement-oplog-metrics-on-streamhub
branch
from
bb1e485
to
2d896b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments