Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UsersInRole not displaying all available rooms for admin #32320

Merged
merged 4 commits into from May 16, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 26, 2024

Proposed changes (including videos or screenshots)

  • ask missing endpoint documentation

Issue(s)

Closes #23437
Closes #21639

Steps to test or reproduce

Further comments

CORE-393

Copy link
Contributor

dionisio-bot bot commented Apr 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: c2726df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title fix: Users in role page not displaying all available rooms for admin fix: UsersInRole not displaying all available rooms for admin Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.85%. Comparing base (776b3c3) to head (c2726df).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32320      +/-   ##
===========================================
+ Coverage    55.84%   55.85%   +0.01%     
===========================================
  Files         2413     2432      +19     
  Lines        53185    53467     +282     
  Branches     10935    10992      +57     
===========================================
+ Hits         29699    29864     +165     
- Misses       20904    20967      +63     
- Partials      2582     2636      +54     
Flag Coverage Δ
e2e 55.18% <90.90%> (+0.03%) ⬆️
unit 72.80% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.9 milestone Apr 26, 2024
@dougfabris dougfabris marked this pull request as ready for review May 10, 2024 18:14
@dougfabris dougfabris requested a review from a team as a code owner May 10, 2024 18:14
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 16, 2024
@kodiakhq kodiakhq bot merged commit c29c69e into develop May 16, 2024
45 of 47 checks passed
@kodiakhq kodiakhq bot deleted the fix/usersInRoleRooms branch May 16, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
2 participants