-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoner defense 2 #2256
Open
rishiso
wants to merge
57
commits into
ros2
Choose a base branch
from
zoner-defense-2
base: ros2
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Zoner defense 2 #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e alive_robots_. Modified type of alive_robots_ almost everywhere to be the std::array<bool, kNumShells> rather than the std::vector<int>
… the new array parameter, made code cleaner for loop in robot_factory_position
…ategy/alive_robots) for consistency
automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
automated style fixes Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com>
sanatd33
requested changes
Apr 24, 2024
rishiso
force-pushed
the
zoner-defense-2
branch
from
April 29, 2024 01:22
489c844
to
5987844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your pull request.
Associated / Resolved Issue
Resolves # or ClickUp card
Design Documents
Link
Steps to Test
Test Case 1
Expected result:???
Key Files to Review
Group 1
Group 2
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.