Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoner defense 2 #2256

Open
wants to merge 57 commits into
base: ros2
Choose a base branch
from
Open

Zoner defense 2 #2256

wants to merge 57 commits into from

Conversation

rishiso
Copy link
Contributor

@rishiso rishiso commented Apr 24, 2024

Description

Describe your pull request.

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1
  2. Step 2
  3. Step 3

Expected result:???

Key Files to Review

Group 1

  • File 1
  • File 2

Group 2

  • File 3
  • File 4

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

Shourik and others added 30 commits March 6, 2024 19:01
…e alive_robots_. Modified type of alive_robots_ almost everywhere to be the std::array<bool, kNumShells> rather than the std::vector<int>
… the new array parameter, made code cleaner for loop in robot_factory_position
automated style fixes

Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
automated style fixes

Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
@rishiso rishiso marked this pull request as ready for review April 24, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants