Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only play placement sound on actions it makes sense for #5092

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hhyyrylainen
Copy link
Member

Brief Description of What This PR Does

A new approach to only play the placement sound when an action succeeded that is of placement or moving type

Related Issues

closes #4578
closes #3386

closes #5069

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.6.1 milestone Apr 30, 2024
@hhyyrylainen
Copy link
Member Author

I'll assume I didn't make any serious bug and merge this for today's build. But can you @CI09 double check?

@hhyyrylainen hhyyrylainen merged commit 85e6132 into master Apr 30, 2024
1 of 4 checks passed
@hhyyrylainen hhyyrylainen deleted the placement_sound_from_action_type branch April 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant