Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make win/extinction text centered #5073

Merged
merged 3 commits into from Apr 30, 2024
Merged

Make win/extinction text centered #5073

merged 3 commits into from Apr 30, 2024

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented Apr 28, 2024

Brief Description of What This PR Does

This PR does some stuff...

Related Issues

Closes #5071

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label Apr 28, 2024
@CI09 CI09 added this to the Release 0.6.7 milestone Apr 28, 2024
@CI09 CI09 requested a review from a team April 28, 2024 13:08
@hhyyrylainen
Copy link
Member

As the issue is that the text is too long, I'm going to turn on word wrapping for the text as well.

Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon testing this I found quite many things I needed to tweak to get the extinction and win boxes working well again.

@hhyyrylainen hhyyrylainen merged commit b07cbc0 into master Apr 30, 2024
1 of 4 checks passed
@hhyyrylainen hhyyrylainen deleted the win_text_fix branch April 30, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The “You're thriving” text goes beyond screen borders
2 participants