Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls Tester: App Store Prep #3889

Merged
merged 22 commits into from
May 15, 2024
Merged

Paywalls Tester: App Store Prep #3889

merged 22 commits into from
May 15, 2024

Conversation

jamesrb1
Copy link
Member

@jamesrb1 jamesrb1 commented May 13, 2024 •
edited

This PR:

  • Updates the bundle name to com.revenuecat.app (a new app in App Store Connect has been set up.)
  • Updates the icon.
  • Update the app's Display Name to Revenue Cat.
  • Removes unneeded keys for "demos" and "testing".
  • Changes how keys are stored/managed locally. I'm not completely happy with this arrangement, but I think it's an improvement because local keys are now stored in a separate file which can be marked as skip-worktree or assume-unchanged which hides them from the diff to help you not commit changes in it accidentally (which I have done).
  • Adds a file in the pre-commit hook to check for keys in LocalConfigItems.swift

For this to compile in release, and the demos tab to show up, the changes from this PR are needed.

@jamesrb1 jamesrb1 added the test Adding missing tests or correcting existing tests label May 13, 2024
@RevenueCat-Danger-Bot
Copy link

RevenueCat-Danger-Bot commented May 13, 2024 •
edited

1 Message
📖 Size increase: 76.00 KB

Generated by 🚫 Danger

@jamesrb1 jamesrb1 requested a review from a team May 14, 2024 22:45
@jamesrb1 jamesrb1 marked this pull request as ready for review May 14, 2024 22:46
@jamesrb1 jamesrb1 changed the title James/paywalls tester/appstore prep Paywalls Tester: App Store Prep May 14, 2024
tonidero
tonidero approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but looks good!

Also, might be worth renaming the folder from PaywallTester to RevenueCatApp or something like that? (in a separate PR)

Tests/TestingApps/PaywallsTester/PaywallsTester.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
...tingApps/PaywallsTester/PaywallsTester/Assets.xcassets/AppIcon.appiconset/appstore1024 1.png Outdated Show resolved Hide resolved
Tests/TestingApps/PaywallsTester/ci_scripts/ci_pre_xcodebuild.sh Outdated Show resolved Hide resolved
@jamesrb1
PR review items
88835c0 
- Add a pre-commit hook to avoid keys being checked in
- Change icon to red RC
- Don’t make backup file when adding key with CI
@jamesrb1
Remove unwanted
ecc36b0
@jamesrb1
Update CI script for key injection
377fcc5
@jamesrb1
Merge branch 'main' of https://github.com/RevenueCat/purchases-ios in…
63b1e50 
…to james/paywalls-tester/appstore-prep
@jamesrb1
script fix
86f31be
@jamesrb1
Do not compile for watchOS
a4b776c
@jamesrb1 jamesrb1 merged commit 1f16a59 into main May 15, 2024
27 of 28 checks passed
@jamesrb1 jamesrb1 deleted the james/paywalls-tester/appstore-prep branch May 15, 2024 22:53
This was referenced May 29, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
test Adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesrb1 @RevenueCat-Danger-Bot @tonidero