Replace CircleCI x86 machines with M1 #3845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the title
Generated by 🚫 Danger |
tonidero
reviewed
Apr 25, 2024
| @@ -785,7 +785,7 @@ jobs: | |||
| release-checks: | |||
| <<: *base-job | |||
| # Fix-me: Carthage can't build fat frameworks on Apple Silicon. See https://github.com/RevenueCat/purchases-ios/pull/3582 | |||
| resource_class: macos.x86.medium.gen2 | |||
| resource_class: macos.m1.medium.gen1 | |||
There was a problem hiding this comment.
We should remove all these comments if it works (I imagine we might need to do some changes?)
joshdholtz
force-pushed
the
circleci-replace-x86-with-m1
branch
from
71de535
to
7336d4a
Compare
vegaro
requested changes
Apr 25, 2024
| @@ -582,7 +582,7 @@ jobs: | |||
| run-test-ios-15: | |||
| <<: *base-job | |||
| # Fix-me: running on M1 makes these tests crash | |||
| resource_class: macos.x86.medium.gen2 | |||
| resource_class: macos.m1.medium.gen1 | |||
There was a problem hiding this comment.
this is already the resource_class in the base-job so I think we can just remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CircleCI removed
macos.x86.medium.gen2Description
Replace
macos.x86.medium.gen2withmacos.m1.medium.gen1