Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevenueCatUI: fade in Loading view #3755

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Mar 7, 2024

This is a proposal, just adding a fade-in effect when first showing the loading view.

I'll get a screen recording of it, but the idea is that since the placeholder view still won't match the actual paywall, and it can lead to perceived "flicker" when it's too fast to really see the placeholder but too slow for it not to show up, maybe the fade makes things a bit smoother.

Still need to try it out more though.

@aboedo aboedo self-assigned this Mar 7, 2024
@RevenueCat-Danger-Bot
Copy link

1 Error
🚫 Label the PR using one of the change type labels
Label Description
breaking Changes that are breaking
build Changes that affect the build system
ci Changes to our CI configuration files and scripts
docs Documentation only changes
feat A new feature
fix A bug fix
perf A code change that improves performance
RevenueCatUI A change to the RevenueCatUI library
refactor A code change that neither fixes a bug nor adds a feature
style Changes that don't affect the meaning of the code (white-space, formatting, missing semi-colons, etc
test Adding missing tests or correcting existing tests
next_release Preparing a new release
dependencies Updating a dependency
phc_dependencies Updating purchases-hybrid-common dependency

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants