Fix bug: shutdown fails when ES not running #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that prevents safe shutdown when EmulationStation is not running. The os.system() calls use && (logical and) statements, which require each command to return 0 on exit, or the next command won't be run. The "sudo killall emulationstation" fails when ES isn't running, such as when the user has pressed F4 to work at the terminal. Thus the system doesn't shut down. Using simple ";" statements sequences the commands without regard to exit status.
d-rez
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that prevents safe shutdown when EmulationStation is not running.
The os.system() calls use && (logical and) statements, which require each command to return 0 on exit, or the next command won't be run. The "sudo killall emulationstation" fails when ES isn't running, such as when the user has pressed F4 to work at the terminal. Thus the system doesn't shut down. Using simple ";" statements sequences the commands without regard to exit status.