Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use old version of chromium #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benperiton
Copy link
Member

@benperiton benperiton commented May 3, 2018

This makes it easy to install this package and use an older version of chromium so that things like #17 work, but it's not very nice having to set the PUPPETEER_CHROMIUM_REVISION=526987 on install as well as in the package.json - not really sure if there is a better way.

To be honest, this might not be needed if someone can figure out why transform:rotate doesn't work, but I'll leave it here in case it helps.

Related to #22

@Zulko
Copy link
Member

Zulko commented May 3, 2018

Hey, I like this PR but is the export PUPPETEER_CHROMIUM_REVISION=526987 mandatory ?
I am trying to make the installation/setup as simple as possible, so that even people with no clue what NPM is can use it.

I'd rather keep the installation instructions clear, and in the future always keep examples and code aligned on the most recent pupetteer and chromium (as I expect improvements).

Then there would be a special section in the docs explaining that for people wanting reliability they can use export PUPPETEER_CHROMIUM_REVISION=526987 (in docker, travis, etc.).

Would that make sense ?

@benperiton
Copy link
Member Author

Yea I'm not overly keen on the export PUPPETEER_CHROMIUM_REVISION=526987 either.
I'll have a look and see if there's a better way to use the default value from puppeteer unless that ENV is set.

@DanielRuf
Copy link
Contributor

cross-env, shelljs / shx could be somehow helpful to give some ideas for possible solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants