added Polish translation #475

nonnullish · 2018-04-01T16:42:14Z

No description provided.

DeeDeeG · 2018-04-03T16:40:01Z

Hello @tusindfryd,

Thank you for the translation! We will look for another native speaker of Polish to review this, and then we can accept/merge.

DeeDeeG · 2018-04-05T16:07:04Z

It may take us some time to find a reviewer, as most of the team has been busy with other responsibilities lately. If we do have any updates for you, we'll post them here. Thanks again for the contribution.

cllns · 2018-04-05T16:53:57Z

@katafrakt Any chance you could take a look at these translations? :)

Here are the English versions: https://github.com/RefugeRestrooms/refugerestrooms/tree/develop/config/locales/en

katafrakt · 2018-04-05T19:17:10Z

@cllns sure, I'm on it

katafrakt

Good effort from @tusindfryd. I have couple of comments though.

And maybe a few more general questions:

Why are Twitter and Facebook in contacts.en.yml without capital letter?
In the pull request, there are couple of files with wrong encoding. Is there a problem with an app (not always using UTF-8) or with a PR?

katafrakt · 2018-04-05T19:19:16Z

config/locales/pl/about.pl.yml

+    title: 'O REFUGE'
+    p1header: 'Czym jest REFUGE Restrooms?'
+    p1:
+      first: 'Refuge Restrooms to aplikacja u�atwiaj�ca osobom transp�ciowym i interp�ciowym bezpieczny dost�p do �azienek publicznych. U�ytkownicy mog� znale�� �azienki znajduj�ce si� w promieniu konkretnej lokalizacji, doda� now� �azienk� do listy, a tak�e skomentowa� i oceni� te dodane ju� wcze�niej.'


"w pobliżu konkretnego miejsca" (promień wymagałby podania liczby, np. w promieniu 5 km od punktu X; lokalizacja jest mało polskim słowem, właściwie kalką językową)

katafrakt · 2018-04-05T19:20:47Z

config/locales/pl/about.pl.yml

+    p2header: 'Sk�d pochodz� wszystkie dane?'
+    p2: 'Pierwsze 4500 lokalizacji pochodzi z danych nieprowadzonego ju� projektu Safe2Pee. Pozosta�e s� dodawane przez u�ytkownik�w. Je�eli zauwa�ysz, �e �azienka w miejscu publicznym jest neutralna, dodaj j� do bazy danych.'
+    p3header: 'Sk�d nazwa REFUGE (ang. azyl)?'
+    p3: 'Chcemy, �eby nasi u�ytkownicy byli godnie traktowani: bezpieczny dost�p do �azienki do podstawowe prawo cz�owieka. Chcemy zapewni� to bezpiecze�stwo ka�demu w razie potrzeby.'


Może zostawić tytuł "Skąd nazwa REFUGE?" i tłumaczenie dodać do p3? To tylko sugestia stylistyczna.

katafrakt · 2018-04-05T19:23:10Z

config/locales/pl/contacts.pl.yml

+pl:
+  contacts:
+    new:
+      request-edit-for-restroom: 'Zasugeruj zmian� w �azience %{restroom_name}'


Polskie znaki się zepsuły chyba tutaj i niżej w tym pliku.

katafrakt · 2018-04-05T19:24:58Z

config/locales/pl/footer.pl.yml

+    footer:
+      aria-labels:
+        github: 'Refuge Restrooms na GitHubie'
+        twitter: 'Refuge Restrooms na twitterze'


Twitter raczej wielką literą

Chociaż widzę że w angielskim oryginale jest małą (podobnie jak Tumblr poniżej)

katafrakt · 2018-04-05T19:26:06Z

config/locales/pl/navigation.pl.yml

+  layouts:
+    navigation:
+      toggle-navigation-button-label: 'Nawigacja'
+      submit-a-new-restroom-hyperlink-label: 'Dodaj �azienk�'


tu również problem z polskimi znakami

katafrakt · 2018-04-05T19:35:19Z

And one more thing: does it make sense to translate text_msg.en.yml? It's an American and there is no mention that texts should be in English. Maybe it's better to tell users it's not available in their language.

nonnullish · 2018-04-06T15:26:32Z

Yeah I messed up the encoding at first. Fixed it now, though. Thanks for the stylistic suggestions :)

katafrakt · 2018-04-06T15:43:03Z

config/locales/pl/restroom.pl.yml

+
+  restrooms:
+    nearby:
+      heading: '£azienki w pobliżu'


One more encoding glitch

katafrakt · 2018-04-06T15:43:21Z

config/locales/pl/signs.pl.yml

+  pages:
+    signs:
+      title: 'Pobierz znaki do łazienek'
+      intro: 'Jeżeli w Twojej placówce znajduje się publiczna łazienka dostępna niezależnie od płci, możesz dodać ją do bazy danych i udostępnić któryś z poniższych znaków. W ten sposób dasz znać odwiedzającym, że cenisz ich bezpieczeñstwo i komfort. Pliki są w formacie PDF, możliwe do wydrukowania w wysokiej rozdzielczości.'


Also here in "bezpieczeństwo"

DeeDeeG · 2018-04-07T07:03:56Z

Hi again,

Thank you @tusindfryd for making updates/changes, and to @katafrakt for the review! Much appreciated!

DeeDeeG · 2018-04-07T07:04:09Z

I'm going to answer some questions that were raised in comments above.

Why are Twitter and Facebook in contacts.en.yml without capital letter?

I think we have "twitter" in lower-case in footer.en.yml, but everything in contacts.en.yml looks properly capitalized, unless I missed something. Twitter is un-capitalized for no particular reason, and perhaps we should change it to "Twitter" with capital "T". (I always thought Twitter themselves styled it "twitter," but I see on their website that they use capital "T." 🤷)

If we do change this, it should be updated across other locales as well (which would be easy to do).

. . . does it make sense to translate text_msg.en.yml? It's an American and there is no mention that texts should be in English. Maybe it's better to tell users it's not available in their language.

I think this service will work no-matter where you text from? (Maybe there are fees associated with international texting.) I think a warning that texts from this service are in English is a fine idea, though. And maybe a warning that you may be charged texting fees. In which case, a warning regarding language/fees should probably be added to the other locales as well.

This page is not linked to from anywhere, so no-one sees it at the moment. Users would need to know to visit this URL: https://refugerestrooms.org/text

I think we should modify our homepage sometime soon to link to the "texting service" page; With that in mind, keeping the translation up-to-date is a good idea in my opinion. And I think changing the text service page to say it is "unavailable in Poland" is perhaps a more-agressive warning than needed. Open to discussion and feedback from anyone on this. Thanks again.

DeeDeeG · 2018-04-09T04:42:33Z

config/locales/pl/text_msg.pl.yml

+pl:
+  pages:
+     text:
+        title: 'Usługa niedostęna w Polsce.'


This PR is already merged, but I forgot to address something.

I believe the SMS feature can be used outside of the U.S. (I haven't tested this personally, but I see no reason why it wouldn't. Again, there might be international texting fees, if your cell service provider charges for that, but it should still work... There may not be many restrooms in Poland yet, but hopefully there willl be some eventually.)

(Also, the responses are simply an address. See: https://github.com/RefugeRestrooms/refugerestrooms/blob/develop/app/assets/images/text-msg-demo.png)

Could I possibly ask you to submit another PR reverting commit 96ec91e, so the Polish translation for this file goes back to being a full translation (not warning users the service won't work outside the U.S.)?

Or would you mind if I just go ahead and revert that commit in our develop branch?

Thanks, and sorry for the oversight in merging before resolving that issue.

Actually, As far as I can tell the SMS service does not work at the moment.

I tried texting the number, and it seems to be in use by Lyft. See this issue for details: #476

For now this PR is fine as-is. Thanks again for this.

added Polish translation

added Polish translation

99c17f1

katafrakt suggested changes Apr 5, 2018

View reviewed changes

nonnullish added 3 commits April 6, 2018 16:49

fixed encoding

73e9f9c

style

f9ca797

tells users that the text message service is unavailable in Poland

96ec91e

katafrakt reviewed Apr 6, 2018

View reviewed changes

config/locales/pl/restroom.pl.yml Outdated

restrooms:

nearby:

heading: '£azienki w pobliżu'

Copy link

katafrakt Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more encoding glitch

katafrakt reviewed Apr 6, 2018

View reviewed changes

fixed encoding again

bcfc4a9

katafrakt approved these changes Apr 6, 2018

View reviewed changes

DeeDeeG merged commit c3aa435 into RefugeRestrooms:develop Apr 9, 2018

DeeDeeG reviewed Apr 9, 2018

View reviewed changes

tkwidmer mentioned this pull request May 18, 2018

Release 1.12.0 #481

Merged

tkwidmer added this to the 1.12.0 milestone May 18, 2018

DeeDeeG added a commit to DeeDeeG/refugerestrooms that referenced this pull request Oct 15, 2018

Merge pull request RefugeRestrooms#475 from tusindfryd/pl

51e0bad

added Polish translation

DeeDeeG added a commit to DeeDeeG/refugerestrooms that referenced this pull request Nov 3, 2018

Merge pull request RefugeRestrooms#475 from tusindfryd/pl

a986c8f

added Polish translation

DeeDeeG mentioned this pull request Nov 5, 2018

Adds translation for miles/kilometers #524

Merged

5 tasks

DeeDeeG added the translations label Dec 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added Polish translation #475

added Polish translation #475

nonnullish commented Apr 1, 2018

DeeDeeG commented Apr 3, 2018

DeeDeeG commented Apr 5, 2018

cllns commented Apr 5, 2018

katafrakt commented Apr 5, 2018

katafrakt left a comment

katafrakt Apr 5, 2018

katafrakt Apr 5, 2018

katafrakt Apr 5, 2018

katafrakt Apr 5, 2018

katafrakt Apr 5, 2018

katafrakt Apr 5, 2018

katafrakt commented Apr 5, 2018

nonnullish commented Apr 6, 2018

katafrakt Apr 6, 2018

katafrakt Apr 6, 2018

DeeDeeG commented Apr 7, 2018

DeeDeeG commented Apr 7, 2018 •

edited

DeeDeeG Apr 9, 2018 •

edited

DeeDeeG Apr 9, 2018

added Polish translation #475

added Polish translation #475

Conversation

nonnullish commented Apr 1, 2018

DeeDeeG commented Apr 3, 2018

DeeDeeG commented Apr 5, 2018

cllns commented Apr 5, 2018

katafrakt commented Apr 5, 2018

katafrakt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katafrakt commented Apr 5, 2018

nonnullish commented Apr 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeeDeeG commented Apr 7, 2018

DeeDeeG commented Apr 7, 2018 • edited

DeeDeeG Apr 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeeDeeG commented Apr 7, 2018 •

edited

DeeDeeG Apr 9, 2018 •

edited