Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish as a Quarto book #11

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Publish as a Quarto book #11

wants to merge 14 commits into from

Conversation

maelle
Copy link

@maelle maelle commented Jul 24, 2023

Fix #10 cc @krlmlr

One usually doesn't do PR from a default branch, but I wanted to be sure the GitHub Actions workflow worked. 馃槄

You can see the result at https://maelle.github.io/Frustration-One-Year-With-R/

If you merge this, for the book to be deployed you'll need

Note that you have some content on R Markdown, that might need to be updated once the document exists as a Quarto book rather than "just" a Markdown README produced with R Markdown.

@@ -0,0 +1,65 @@
# from the babeldown package
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this script is how I created the Quarto book. I also had to make a few manual tweaks in the Rmd that ends up in what_r_does_wrong.qmd (white space) for the conversion to go well.

@maelle

This comment was marked as resolved.

@@ -0,0 +1,22 @@
tackle_title <- function(title) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is the script I used for fixing cross-references 馃槄

@ReeceGoding
Copy link
Owner

Very interesting! I'm not quite sure what I'll do with this (I know virtually nothing about Quarto), but I'll take a closer look at some point and maybe do as you have suggested.

I think the indentation is slightly off. There are some code-blocks-followed-by-text inside bullet points. In the original, I was allowed to put the post-code text on the same level of indentation as the pre-code text. This version seems to always reset the indentation after the code block. Compare section 4.5.2 in both.

@maelle
Copy link
Author

maelle commented Jul 25, 2023

Very interesting! I'm not quite sure what I'll do with this (I know virtually nothing about Quarto), but I'll take a closer look at some point and maybe do as you have suggested.

No pressure, and feel free to ask any question about Quarto (note that I will be off the first three weeks of August, so don't be surprised if my answers are a bit delayed 馃槆 )

I think the indentation is slightly off. There are some code-blocks-followed-by-text inside bullet points. In the original, I was allowed to put the post-code text on the same level of indentation as the pre-code text. This version seems to always reset the indentation after the code block. Compare section 4.5.2 in both.

Oh right! This happened only for indented code blocks with a blank line before them, probably because tinkr that I used for the transformation, so Commonmark under the block, considered the text after an item after a blank line to not be part of that list item. I made manual fixes, but please tell me if I missed some of them. I'm sorry about these small (or not so small) discrepancies.

Note that it seems fitting that it happens in the "what R does wrong" chapter, but I'm pretty sure it's a Commonmark issue, not an R issue. 馃樃

@maelle
Copy link
Author

maelle commented Jul 25, 2023

Hmm actually that indent fixing didn't work. 馃

@maelle
Copy link
Author

maelle commented Jul 25, 2023

all fixed now -- sorry about the flurry of commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish as a Quarto book?
2 participants