Fixing ios front camera crash issue. #979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this could be merged into the 3.0 branch too? I'd like to use it in a project that doesn't support Xamarin Form 5.0 yet as it has other conflicting dependencies that I can't remove yet. |
|
We would also be interested in having this fix merged into the master as we are facing the very same issue when attempting to switch from front to back camera. Interestingly, when switching from back to front we could not observe this crash. |
|
please merge.... |
|
Please merge |
|
bump |
|
Please, when will it be merged and new release will appear? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the crash to be related to trying to set an unsupported focus mode on the camera. To fix it I've added a check using
IsFocusModeSupport()to make sure it is ok to set the focus mode back to the original.#978