Add GTK support #798

mierzynskim · 2019-01-16T13:09:52Z

This PR will add rendering support for GTK #797. PR also includes example for both native GTK and XF backend.
Implementation of drawing an individual pixel may look like a little bit odd but I think that's the most readable version that can be achieved with GTK.
I wasn't sure how to tackle nuspec files for GTK but I assumed we can use the same convention as Xamarin Forms GTK backend and use net45 as target framework (see here).

knocte · 2019-01-16T13:58:23Z

hey @mierzynskim you targetted the wrong branch, can you apply to 'dev' branch instead?

mierzynskim · 2019-01-16T14:24:40Z

@knocte yes, sure. Now I targeted dev branch

knocte · 2019-01-16T14:26:52Z

Samples/Forms/Sample.Forms.sln.DotSettings.user

@@ -0,0 +1,23 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">


this is a file from your IDE, I think, please remove it from the PR

knocte · 2019-01-16T14:29:56Z

readme.md

@@ -4,7 +4,8 @@

 ![ZXing.Net.Mobile Logo](https://raw.github.com/Redth/ZXing.Net.Mobile/master/zxing.net.mobile_128x128.png)

-ZXing.Net.Mobile is a C#/.NET library based on the open source Barcode Library: [ZXing (Zebra Crossing)](https://github.com/zxing/zxing), using the [ZXing.Net Port](https://github.com/micjahn/ZXing.Net).  It works with Xamarin.iOS, Xamarin.Android, Xamarin.Mac, and Windows Phone.  The goal of ZXing.Net.Mobile is to make scanning barcodes as effortless and painless as possible in your own applications.  The new iOS7 AVCaptureSession barcode scanning is now also supported!
+
+ZXing.Net.Mobile is a C#/.NET library based on the open source Barcode Library: [ZXing (Zebra Crossing)](https://github.com/zxing/zxing), using the [ZXing.Net Port](https://github.com/micjahn/ZXing.Net).  It works with Xamarin.iOS, Xamarin.Android,Xamarin.Mac, GTK# and Windows Phone.  The goal of ZXing.Net.Mobile is to make scanning barcodes as effortless and painless as possible in your own applications.  The new iOS7 AVCaptureSession barcode scanning is now also supported!


nit: missing a space before "Xamarin.Mac"

knocte · 2019-01-16T14:36:24Z

Samples/GTK/gtk-gui/MainWindow.cs

+		this.Show();
+		this.DeleteEvent += new global::Gtk.DeleteEventHandler(this.OnDeleteEvent);
+	}
+}


nit: use spaces instead of tabs in this file

I think we can change it because it's autogenerated file 😞

knocte · 2019-01-16T14:36:57Z

Samples/GTK/gtk-gui/generated.cs

+			return null;
+		}
+	}
+}


same nit here: spaces instead of tabs

same as above

knocte · 2019-01-16T14:46:46Z

Mmm, CI doesn't pass because of a weird NuGet error related to .sln or .csproj files:

Executing: "C:/projects/zxing-net-mobile/tools/NuGet.exe" restore "C:/projects/zxing-net-mobile/ZXing.Net.Mobile.Forms.sln" -NonInteractive
MSBuild auto-detection: using msbuild version '15.9.21.664' from 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\bin'.
Error parsing solution file at C:\projects\zxing-net-mobile\ZXing.Net.Mobile.Forms.sln: Exception has been thrown by the target of an invocation.  Error parsing the nested project section in solution file. A project with the GUID "{A7E26AE0-12AF-4CFD-9B1E-3101347CC6F4}" is listed as being nested under project "{2DC0C8D5-DF7F-4D96-886D-D7E83522C9BF}", but does not exist in the solution.  C:\projects\zxing-net-mobile\ZXing.Net.Mobile.Forms.sln
An error occurred when executing task 'libs'.
Error: System.AggregateException: One or more errors occurred. ---> Cake.Core.CakeException: NuGet: Process returned an error (exit code 1).

Did you edit these files manually instead of letting VS change them? :)

mierzynskim · 2019-01-16T15:00:20Z

Hmm, I think CI doesn't have GTK installed... I thought it's shipped with Mono by default. I'll add it as external library

knocte · 2019-01-16T15:09:27Z

Not sure adding it as external lib is the best approach. Maybe download the .msi file that installs these libs and install it non-interactively from the cake files?

knocte · 2019-01-16T15:10:50Z

Or this? https://chocolatey.org/packages/gtksharp

mierzynskim · 2019-01-16T15:12:30Z

Hard to say. That's the approach XF chose https://github.com/xamarin/Xamarin.Forms/tree/master/Xamarin.Forms.Platform.GTK/Libs

knocte · 2019-01-16T15:14:07Z

ah ok! if that's the case, you could do the same I guess, just grab the exact same binaries

See Redth#798 Fixes Redth#797

mierzynskim · 2019-01-28T09:53:03Z

@Redth I think we have a final version now. I also tested it and it looks like it works fine. Please have a look when you have some time.

rblanca · 2019-09-03T10:49:02Z

Any news? Thanks

knocte · 2020-02-25T06:34:17Z

@rblanca we have this merged in this fork in case you're interested: https://github.com/nblockchain/ZXing.Net.Xamarin (we also publish this fork on nuget)

knocte · 2020-03-15T15:37:07Z

@Redth can you include this in 3.0?

Redth · 2020-03-15T15:40:58Z

@knocte I'm super hesitant to add this into the main package, mostly because https://github.com/Redth/ZXing.Net.Mobile/pull/798/files?file-filters%5B%5D=.nuspec#diff-978f915984ac9573cd5e42dfc0550c3fR82-R83

The TFM of net45 isn't really appropriate to use in the main package if the binaries are specifically for GTK apps.

What we maybe could do is release a separate package of ZXing.Net.Mobile.GTK with these binaries in it.

Redth · 2020-03-15T15:41:27Z

@knocte any interest in trying to rebase this PR's work on current master?

knocte · 2020-03-15T15:53:56Z

The TFM of net45 isn't really appropriate to use in the main package if the binaries are specifically for GTK apps.

What do you mean? what's the issue exactly? I've been using this code for a while now and works perfectly. The proof is this fork we publish on nuget: https://github.com/nblockchain/ZXing.Net.Xamarin and the app that consumes it: https://github.com/nblockchain/geewallet

Redth · 2020-03-15T16:09:20Z

The problem is if I ship code that depends on GTK into an assembly which is in the net45 TFM, and someone tries to install and use the package in say a windows console app, they aren’t going to have a good time of it. Because there is no TFM that exists to pivot on GTK support directly, there’s limited options.

Ship it in a separate nuget package such as ZXing.Net.Mobile.GTK (and use net45 for that) - this is a bit more explicit since you have to opt in by installing the nuget package intentionally which means you likely understand what you are doing and won’t try and use it in the wrong type of app.
See if there’s any sort of MSBuild property that is exposed when an app uses GTK and use a .targets file in the main nuget package to pivot on which assembly gets referenced. This is kind of weird if there isn’t any other non-GTK implementation shipping (which there currently is not).

Basically 1 is less discoverable but much easier to implement than 2.

I’m leaning towards option 1.

knocte · 2020-03-15T16:14:27Z

and use the package in say a windows console app,

But this is not supported by ZXing.Net.Mobile anyway AFAIU, why not just put a warning about this on the Readme?

Redth · 2020-03-15T16:17:58Z

It's not supported today, but it could be one day. That alone may not be a good enough reason, but generally the practice we use at Microsoft is to use a separate package name for GTK stuff. Take Xamarin.Forms.Platform.GTK for instance.

I think the right thing to do here is the separate package (and one for the Forms implementation too). This means separate .csproj's which I don't love, but I think this is the right choice

knocte · 2020-03-15T16:21:50Z

It's not supported today, but it could be one day.

One day? AFAIU net45 is the old framework; and these days in the .NET community people are even advocating to stop supporting it because "legacy" and just support .NETCore, why would anyone go in the other direction?

Anyway I understand the point of view (I use GTK myself with Xamarin.Forms) but it looks a bit ugly (because the other nonGTK platforms don't have a separate nuget package).

Redth · 2020-03-15T16:24:49Z

Yes, net45 is old, however net5 is coming, the same problem will exist there. There will be no platform TFM for GTK pivoting. The point is more about unintentionally expressing support for a TFM which you do not actually support. Yes this is still true of a .GTK package but as I said, it's a bit more explicit by naming and the intentional additional install helps to avoid confusion.

Yeah more nuget refs in a project stinks, but I definitely think the trade off is ok in this case.

knocte · 2020-03-16T13:37:50Z

any interest in trying to rebase this PR's work on current master?

I have interest :) What I'm not sure is if I have time. Especially considering that even if I did the effort of rebasing it, I couldn't adopt the new 3.x verison of ZXing.Net.Mobile right away, because I just realised that you introduced Xamarin.Essentials as a dependency :( What was the motivation for that? It basically would break our setup because XamEssentials doesn't support macOS and Linux+GTK platforms.

Based on Redth#798 Fixes Redth#797

Upstream PR: Redth#798 Fixes Redth#797

mierzynskim added 8 commits January 14, 2019 13:40

Added support for barcode rendering for GTK

23e0183

Added support for XF GTK backend

78e7659

Improved XF renderer performance

46eda14

Downgraded XF to latest version with GTK support

2a9ec55

Fixed and simplified pixel drawing

c01c561

Nuspec changes for gtk rendering support

990ed23

Fixed assembly info

0d0a29b

Fixed one more assembly info

43eca9f

mierzynskim changed the title ~~Add GTK support Close #797~~ Add GTK support Jan 16, 2019

gitcoinbot mentioned this pull request Jan 16, 2019

Rendering support for GTK platform #797

Closed

mierzynskim changed the base branch from master to dev January 16, 2019 14:19

Merge branch 'dev' into gtkSupport

f7eb6f1

knocte reviewed Jan 16, 2019

View reviewed changes

Removed redundant .user file and updated readme

120157c

knocte reviewed Jan 16, 2019

View reviewed changes

Resolve sln error that appeared during the merge

1cb223a

mierzynskim and others added 4 commits January 17, 2019 11:19

Added GTK dependencies to the project

9d9f2c8

Updated XF to 3.0.0.446417 to fix build problems

7c7debe

Referenced netstandard in XF UWP project

3982cc1

Removed .user files and added them to gitignore

b62b6de

knocte pushed a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Jan 24, 2019

GTK rendering support

53f85f6

See Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

266557f

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

795fc37

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

a3fdffa

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

b21492e

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

9694667

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

2707763

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

10104ab

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

d723f42

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Sep 17, 2020

GTK rendering support

864fd16

Based on Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

b5b7274

Upstream PR: Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

a360c92

Upstream PR: Redth#798 Fixes Redth#797

knocte added a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

5cbbb55

Upstream PR: Redth#798 Fixes Redth#797

knocte pushed a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

b4c8f30

Upstream PR: Redth#798 Fixes Redth#797

knocte pushed a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

339c68f

Upstream PR: Redth#798 Fixes Redth#797

knocte pushed a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

c0baa0d

Upstream PR: Redth#798 Fixes Redth#797

knocte pushed a commit to nblockchain/ZXing.Net.Xamarin that referenced this pull request Aug 14, 2022

GTK rendering support

a2aea05

Upstream PR: Redth#798 Fixes Redth#797

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GTK support #798

Add GTK support #798

mierzynskim commented Jan 16, 2019 •

edited

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte Jan 16, 2019

knocte Jan 16, 2019

knocte Jan 16, 2019 •

edited

mierzynskim Jan 16, 2019

knocte Jan 16, 2019

knocte Jan 16, 2019

mierzynskim Jan 16, 2019

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte commented Jan 16, 2019

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte commented Jan 16, 2019

mierzynskim commented Jan 28, 2019

rblanca commented Sep 3, 2019

knocte commented Feb 25, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 16, 2020

		@@ -0,0 +1,23 @@
		<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">

Add GTK support #798

Are you sure you want to change the base?

Add GTK support #798

Conversation

mierzynskim commented Jan 16, 2019 • edited

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte Jan 16, 2019

Choose a reason for hiding this comment

knocte Jan 16, 2019

Choose a reason for hiding this comment

knocte Jan 16, 2019 • edited

Choose a reason for hiding this comment

mierzynskim Jan 16, 2019

Choose a reason for hiding this comment

knocte Jan 16, 2019

Choose a reason for hiding this comment

knocte Jan 16, 2019

Choose a reason for hiding this comment

mierzynskim Jan 16, 2019

Choose a reason for hiding this comment

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte commented Jan 16, 2019

knocte commented Jan 16, 2019

mierzynskim commented Jan 16, 2019

knocte commented Jan 16, 2019

mierzynskim commented Jan 28, 2019

rblanca commented Sep 3, 2019

knocte commented Feb 25, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 15, 2020

Redth commented Mar 15, 2020

knocte commented Mar 16, 2020

mierzynskim commented Jan 16, 2019 •

edited

knocte Jan 16, 2019 •

edited