Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZXingScannerViewRenderer was causing the app to crash if the view was inside a ContentView #1060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZXingScannerViewRenderer was causing the app to crash if the view was inside a ContentView #1060

wants to merge 1 commit into from

Commits on Dec 8, 2022

  1. ZXingScannerViewRenderer was causing the app to crash if the view was… 

    … inside a ContentView

If the `ZXingScannerView` was inside of a `ContentView` instead of a `ContentPage`, the application would crash by throwing a `Java.Lang.NullPointerException`. The `Context` passed to `ZXingScannerViewRenderer` via the constructor was actually a `ContextThemeWrapper` which does not inherit from `Activity`. Therefore when it was cast in the call of the constructor of `ZXingScannerView` in the renderer on Android, a `null` would be passed for a context instead.

Fixes: Redth#943
    @seansparkman
    seansparkman committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    aefb694 View commit details
    Browse the repository at this point in the history