Bug fix: Torch wasn't working #1028
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null check of out parameter "err" should be if(err == null) rather than != null. Otherwise device.TorchMode is generally unreachable.
wcoder
reviewed
Dec 9, 2022
Comment on lines
621
to
+623
| device.LockForConfiguration(out var err); | ||
|
|
||
| if (err != null) | ||
| if (err == null) |
There was a problem hiding this comment.
Better to check the result of the operation instead:
Suggested change
| device.LockForConfiguration(out var err); | |
| if (err != null) | |
| if (err == null) | |
| if (device.LockForConfiguration(out var err)) |
|
@Redth Could you please check this small PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null check of
outparametererrshould beif (err == null)rather thanif (err != null).Otherwise
device.TorchModeis generally unreachable.Amending it as per the pull request fixes
viewController?.ToggleTorch()which previously wasn't working in iOS.