Renamed/deprecated flexible datasources and resources (subscriptions and databases) #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSharpe
requested review from
trentrosenbaum,
wjam,
Hiieu,
pvegh-oc,
greg-oc and
byron-oc
greg-oc
approved these changes
May 9, 2024
|
|
||
| The `alert` block supports: | ||
|
|
||
| * `name` The alert name |
There was a problem hiding this comment.
Suggested change
| * `name` The alert name | |
| * `name` - The alert name |
super pedantic but think it would look better like this
| The `alert` block supports: | ||
|
|
||
| * `name` The alert name | ||
| * `value` The alert value |
There was a problem hiding this comment.
Suggested change
| * `value` The alert value | |
| * `value` - The alert value |
| layout: "rediscloud" | ||
| page_title: "Redis Cloud: rediscloud_flexible_database" | ||
| description: |- | ||
| Database resource in the Terraform provider Redis Cloud. |
There was a problem hiding this comment.
Suggested change
| Database resource in the Terraform provider Redis Cloud. | |
| Database resource in the Redis Cloud Terraform provider. |
| layout: "rediscloud" | ||
| page_title: "Redis Cloud: rediscloud_flexible_subscription" | ||
| description: |- | ||
| Flexible Subscription data source in the Terraform provider Redis Cloud. |
There was a problem hiding this comment.
Suggested change
| Flexible Subscription data source in the Terraform provider Redis Cloud. | |
| Flexible Subscription data source in the Redis Cloud Terraform provider. |
| layout: "rediscloud" | ||
| page_title: "Redis Cloud: rediscloud_flexible_subscription" | ||
| description: |- | ||
| Flexible Subscription resource in the Terraform provider Redis Cloud. |
There was a problem hiding this comment.
Suggested change
| Flexible Subscription resource in the Terraform provider Redis Cloud. | |
| Flexible Subscription resource in the Redis Cloud Terraform provider. |
| data "rediscloud_payment_method" "card" { | ||
| card_type = "Visa" | ||
| } | ||
| resource "rediscloud_subscription" "subscription-resource" { |
There was a problem hiding this comment.
shouldn't the resource now be called rediscloud_flexible_subscription in the example?
|
|
||
| ## Import | ||
|
|
||
| `rediscloud_subscription` can be imported using the ID of the subscription, e.g. |
There was a problem hiding this comment.
Suggested change
| `rediscloud_subscription` can be imported using the ID of the subscription, e.g. | |
| `rediscloud_flexible_subscription` can be imported using the ID of the subscription, e.g. |
There was a problem hiding this comment.
BTW, there might be other cases like this that I've missed
JohnSharpe
force-pushed
the
4-flexible
branch
3 times, most recently
from
ecd9cf3
to
c3c27eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.