-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did some language clean up / clarification on JSON.MERGE
documentaiton page.
#1065
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 15 15
Lines 3853 3853
=======================================
Hits 3051 3051
Misses 802 802 ☔ View full report in Codecov by Sentry. |
docs/commands/json.merge.md
Outdated
|
||
[Examples](#examples) | ||
|
||
## Required arguments | ||
|
||
<details open><summary><code>key</code></summary> | ||
|
||
is key to merge into. | ||
is the key to merge into. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what Nermina called "telegraphic writing style". She introduced this style in all module commands that she touched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange as it makes it sound like broken English also something being "key" in this sense means important. "is key to our understanding etc." Let's run without the "the" but this style is detrimental IMHO.
docs/commands/json.merge.md
Outdated
</details> | ||
|
||
<details open><summary><code>path</code></summary> | ||
|
||
is JSONPath to specify. For non-existing keys the `path` must be `$`. For existing keys, for each matched `path`, the value that matches the `path` is being merged with the JSON `value`. For existing keys, when the path exists, except for the last element, a new child is added with the JSON `value`. | ||
is the JSONPath to specify where in the JSON document to apply the merge. For non-existing keys the `path` must be `$`. For existing keys, for each matched `path`, the value that matches the `path` is merged with the JSON `value`. For existing keys, when the path exists, except for the last element, a new child is added with the JSON `value`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the "the"
|
||
</details> | ||
|
||
<details open><summary><code>value</code></summary> | ||
|
||
is JSON value to merge with at the specified path. Merging is done according to the following rules per JSON value in the `value` argument while considering the corresponding original value if it exists: | ||
is the JSON value to merge with at the specified path. Merging is done according to the following rules per JSON value in the `value` argument while considering the corresponding original value if it exists: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
</details> | ||
|
||
## Return value | ||
|
||
JSET.MERGE returns a simple string reply: `OK` if executed correctly or `error` if fails to set the new values | ||
JSET.MERGE returns a simple string reply: `OK` if executed correctly or `error` if fails to set the new values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON.MERGE ;-)
Removed a couple of instances of "the" to stick with the style.
No description provided.