Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMP make MT_MODE mutable #4624

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented May 7, 2024

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. The current state briefly
  2. What is the change
  3. Adding the outcome (changed state)

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@GuyAv46 GuyAv46 marked this pull request as ready for review May 7, 2024 14:26
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.80%. Comparing base (98ddf4b) to head (ec481f3).
Report is 3 commits behind head on master.

Files Patch % Lines
src/result_processor.c 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4624      +/-   ##
==========================================
+ Coverage   85.78%   85.80%   +0.02%     
==========================================
  Files         188      188              
  Lines       33108    33146      +38     
==========================================
+ Hits        28402    28442      +40     
+ Misses       4706     4704       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 marked this pull request as draft May 7, 2024 15:07
@GuyAv46 GuyAv46 marked this pull request as ready for review May 9, 2024 06:38
* minor cleanup

* initial solution preparations

* implement `SetLoadersForBG` and `SetLoadersForMainThread`

* minor fixes

* add first test

* improve test

* move flag marking into RPLoader_New

* test cleanup

* another test improvement

* minor test improvement

* another test improvement

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant