Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic loader RP - [MOD-6573] #4623

Merged
merged 12 commits into from May 15, 2024

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented May 7, 2024

Describe the changes in the pull request

Support modifying the RP pipeline when the execution thread is different from the one the pipeline was built for (relevant for cursors only)

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.81%. Comparing base (7c86606) to head (f005832).

Files Patch % Lines
src/result_processor.c 97.91% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feature-runtime_scaling_config    #4623      +/-   ##
==================================================================
+ Coverage                           85.79%   85.81%   +0.01%     
==================================================================
  Files                                 188      188              
  Lines                               33107    33147      +40     
==================================================================
+ Hits                                28405    28444      +39     
- Misses                               4702     4703       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 requested a review from meiravgri May 9, 2024 12:21
Copy link
Collaborator

@meiravgri meiravgri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple and clean solution
well done!

src/cursor.h Outdated Show resolved Hide resolved
src/aggregate/aggregate_exec.c Show resolved Hide resolved
src/aggregate/aggregate.h Outdated Show resolved Hide resolved
src/result_processor.c Show resolved Hide resolved
src/result_processor.c Outdated Show resolved Hide resolved
src/result_processor.c Show resolved Hide resolved
tests/pytests/test_multithread.py Show resolved Hide resolved
@GuyAv46 GuyAv46 requested a review from meiravgri May 12, 2024 15:20
@GuyAv46 GuyAv46 requested a review from raz-mon May 12, 2024 15:41
Copy link
Collaborator

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exquisite! 🔥 💯

@GuyAv46 GuyAv46 merged commit ec481f3 into feature-runtime_scaling_config May 15, 2024
10 checks passed
@GuyAv46 GuyAv46 deleted the guyav-dynamic_loader branch May 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants