Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSValue array cleanup #4612

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

RSValue array cleanup #4612

wants to merge 4 commits into from

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Apr 30, 2024

Describe the changes in the pull request

Remove unnecessary initialization and branching

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@GuyAv46 GuyAv46 requested a review from oshadmi April 30, 2024 11:48
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.79%. Comparing base (70fc0b8) to head (7942a4b).

Files Patch % Lines
src/rlookup.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4612      +/-   ##
==========================================
- Coverage   85.80%   85.79%   -0.02%     
==========================================
  Files         188      188              
  Lines       33120    33098      -22     
==========================================
- Hits        28418    28395      -23     
- Misses       4702     4703       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant