[2.8] MOD-6178: [GeoPoly] Intersects Disjoint (#4227) #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * some code repition * finally managed to remove code duplication. unfortunately required a macro. still worth it * formatting * comment * combining predicate and filter into unified predicate * combining predicate and filter necessitates reversing the filter * no macros * no need to send query_geom to apply_predicate * adding tests * adding correction to point MBR to use the literal minimal possible bounding rectangle * adding self-intersection/disjoint test * adding hole to tests
oshadmi
approved these changes
Dec 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #4251 +/- ##
==========================================
+ Coverage 83.23% 83.30% +0.07%
==========================================
Files 192 192
Lines 33679 33715 +36
==========================================
+ Hits 28032 28086 +54
+ Misses 5647 5629 -18 ☔ View full report in Codecov by Sentry. |
|
This pull request is stale because it has been open for 60 days with no activity. |
|
Is this still intended to be merged into 2.8, or when can we expect this to be available in a general release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4227 to 2.8.