Combine Interoperability: first iteration #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/combine-interop
branch
from
dce8b0a
to
d7b1a5d
Compare
dsaliberti
reviewed
May 23, 2020
| let (shouldSendImmediately, isDemandUnlimited): (Bool, Bool) = self.state.modify { state in | ||
| guard state.hasCancelled == false else { return (false, false) } | ||
|
|
||
| let unsatified = state.requested - state.satisfied |
esilverberg
reviewed
Nov 17, 2020
| } | ||
|
|
||
| final class ProducerSubscription<S: Subscriber>: Combine.Subscription { | ||
| typealias Output = S.Output |
esilverberg
reviewed
Nov 17, 2020
| return .startUpstream | ||
| } | ||
|
|
||
| state.requested = state.requested + incoming |
There was a problem hiding this comment.
This can be rewritten state.requested += incoming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide explicit means to convert any Combine publisher to
SignalProducer, and to convert RAS primitives to aPublisher(basic backpressure support included for Combine compliance).Interoperability for
SchedulerandDisposableis not yet considered, since they have incompatible API contracts with their Combine counterparts.Checklist