Updated rmg_runner.py and test_rmg_runner.py #86
+109
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmg_runner.py: File has been updated with assertion checks to ensure the user is correctly choosing memory if they specifiy test_rmg_runner.py: Test has descriptions and also checks for assertion errors when the memory is incorrectly specified.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test_rmg_runner.py: Updated the class TestWriteSubmitScript with a function that runs executes t3 as a 'local' job, and then after 'converging' the function will ensure that the job.sh and submit.sub files are written as expected.
os.remove error that there was no job.sh to remove. Therefore, removed the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmg_runner.py: File has been updated with assertion checks to ensure the user is correctly choosing memory if they specifiy
test_rmg_runner.py: Test has descriptions and also checks for assertion errors when the memory is incorrectly specified.