New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Species err #78

Open

NaveDanan wants to merge 4 commits into main from species_err

NaveDanan commented Mar 18, 2022

This patch try fix the issue where species are unable to load properly, and SA can not be performed.

Nave Danan added 4 commits

March 17, 2022 22:18


          Fixed env specs

66c6fe7


          Fixed condition in schema check_pdep_only_if_gas_phase

26d47ea


          Fixed T0 and P0 can be list or scalar

d26780c


          Fixed in case of noneType species get speices via stracture

6355f16

NaveDanan requested a review from alongd

March 18, 2022 08:30

github-actions bot added Module main Module schema Module simulate labels

Member

alongd commented Mar 19, 2022

There's an environment conflict. We once had that in RMG and in ARC, let's solve this first so the test will run, then look at the content of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment