Pdep fixes #60
Open
Pdep fixes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 74.98% 70.11% -4.87%
==========================================
Files 9 9
Lines 1491 1499 +8
Branches 381 384 +3
==========================================
- Hits 1118 1051 -67
- Misses 238 323 +85
+ Partials 135 125 -10
Continue to review full report at Codecov.
|
alongd
force-pushed
the
pdep_fixes
branch
3 times, most recently
from
c7389b3
to
77c68bf
Compare
not a dict. Note that it is a dict under `check_species_and_reactors()` which is a root_validator, on line 503. Cofusing, but crashes otherwise
when running RMG with PDep
The first iteration will assign the value from this dictionary to pdep['method', the T3 will crash at the second iteration, since the corresponding value is not a key in this dict. Here we first check whether the value is already correct, if not we use the mapping dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three bug fixes:
Please don't merge yet, I should add tests