Enabling modeling 5=5 reactions #201
Open
+2,586
−692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR ready for review? If so could you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, some models (e.g., from KAUST or NUIG) have 5 reactants/products. Since Chemkin/Cantera is able to deal with such cases, I think RMS should support it as well.
This PR follows how things are done in PR #193. Given the current architecture of RMS, the major challenges come from getting the correct jacobian for reactions with 5 parties involved. I typed these manually in the hope of being error-free. This will also be the major challenge of this PR review.