Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed rxns comments that started with the word fit #626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NellyMitnik
Copy link

I got the following trace when simulating an RMG-genrated Chemkin file usng RMG's constant T/P reactor:

[/tmp/ipykernel_1667806/515436996.py](https://file+.vscode-resource.vscode-cdn.net/tmp/ipykernel_1667806/515436996.py) in 
      1 species, reactions = load_chemkin_file(path=chemkin_path,
----> 2                                        dictionary_path=dict_path
      3                                       )

[~/Code/RMG-Py/rmgpy/chemkin.pyx](https://file+.vscode-resource.vscode-cdn.net/home/nelly/Code/scripts/NPS/~/Code/RMG-Py/rmgpy/chemkin.pyx) in rmgpy.chemkin.load_chemkin_file()

[~/Code/RMG-Py/rmgpy/chemkin.pyx](https://file+.vscode-resource.vscode-cdn.net/home/nelly/Code/scripts/NPS/~/Code/RMG-Py/rmgpy/chemkin.pyx) in rmgpy.chemkin.load_chemkin_file()

[~/Code/RMG-Py/rmgpy/chemkin.pyx](https://file+.vscode-resource.vscode-cdn.net/home/nelly/Code/scripts/NPS/~/Code/RMG-Py/rmgpy/chemkin.pyx) in rmgpy.chemkin.read_reactions_block()

[~/Code/RMG-Py/rmgpy/chemkin.pyx](https://file+.vscode-resource.vscode-cdn.net/home/nelly/Code/scripts/NPS/~/Code/RMG-Py/rmgpy/chemkin.pyx) in rmgpy.chemkin.read_reactions_block()

[~/Code/RMG-Py/rmgpy/chemkin.pyx](https://file+.vscode-resource.vscode-cdn.net/home/nelly/Code/scripts/NPS/~/Code/RMG-Py/rmgpy/chemkin.pyx) in rmgpy.chemkin.read_reaction_comments()

ChemkinError: Unexpected species identifier fit encountered in flux pairs for reaction VA(28) + C6H5(126) <=> W1-2(1174).

RMG did not read the flux pair correctly from C6H5_C4H4_Mebel kinetic library, and read the following line which was taken from the library comment.

This is the reaction it errored on:

! Library reaction: C6H5_C4H4_Mebel
! Flux pairs: VA(28), W1-2(1174); C6H5(126), W1-2(1174); 
! fit btw. 500 and 1375 K with MAE of 1.9%, 4.6%
! fit btw. 500 and 1650 K with MAE of 2.8%, 6.0%
! fit btw. 500 and 1800 K with MAE of 2.5%, 4.6%
! fit btw. 500 and 2250 K with MAE of 3.7%, 12.1%
VA(28)+C6H5(126)=W1-2(1174)                         1.000e+00 0.000     0.000    
    PLOG/ 0.039470  3.620e+84 -21.480   42.190   /
    PLOG/ 0.039470  2.160e+43 -10.070   12.890   /
    PLOG/ 1.000000  2.630e+69 -16.520   40.770   /
    PLOG/ 1.000000  2.890e+26 -4.680    7.584    /
    PLOG/ 10.000000 7.590e+49 -10.650   32.900   /
    PLOG/ 10.000000 1.040e+17 -1.720    4.254    /
    PLOG/ 100.000000 1.350e+27 -4.110    18.320   /
    PLOG/ 100.000000 1.270e+20 -2.720    5.193    /

For a quick solution while using rmg.chemkin.load_chemkin_file, I removed all the comments inside the reactions comments that started with the word 'fit' inside the C6H5_C4H4_Mebel library.

@NellyMitnik NellyMitnik requested a review from alongd June 26, 2023 13:26
@NellyMitnik
Copy link
Author

I am attaching the chemkin and the dictionary files:
chem_edge_annotated.txt
species_edge_dictionary.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant