Skip to content

Commit

Permalink
allow cat of regression diff to fail, print a warning instead
Browse files Browse the repository at this point in the history
this will allow the regression test results to all be reported even if there is such a huge difference between the dynamic and baseline that the system utilities cannot print it

see: #2316 (comment)
  • Loading branch information
JacksonBurns authored and rwest committed Apr 1, 2024
1 parent e89bbb2 commit 44bb167
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Expand Up @@ -272,7 +272,7 @@ jobs:
export FAILED=Yes
fi
echo "" # blank line so next block is interpreted as markdown
cat "$regr_test-core.log"
cat "$regr_test-core.log" || (echo "Dumping the whole log failed, please download it from GitHub actions. Here are the first 100 lines:" && head -n100 "$regr_test-core.log")
echo "</details>"
echo "<details>"
if python-jl scripts/checkModels.py \
Expand All @@ -289,7 +289,7 @@ jobs:
export FAILED=Yes
fi
echo "" # blank line so next block is interpreted as markdown
cat "$regr_test-edge.log"
cat "$regr_test-edge.log" || (echo "Dumping the whole log failed, please download it from GitHub actions. Here are the first 100 lines:" && head -n100 "$regr_test-core.log")
echo "</details>"
# Check for Regression between Reference and Dynamic (skip superminimal)
Expand Down

0 comments on commit 44bb167

Please sign in to comment.