Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "calcfc" in Gaussian only for non monoatomic species #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alongd
Copy link
Member

@alongd alongd commented Nov 1, 2020

This PR removes the Gaussian "calcfc" keyword from the opt keyword list for monoatomic species. Issue detected by @mjohnson541, fix suggested by @dranasinghe

fixes #435

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #436 (28a5fc8) into master (20e68d2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   54.07%   54.06%   -0.02%     
==========================================
  Files          38       38              
  Lines       12112    12115       +3     
  Branches     3741     3742       +1     
==========================================
  Hits         6550     6550              
- Misses       4580     4583       +3     
  Partials      982      982              
Impacted Files Coverage Δ
arc/job/job.py 21.72% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e68d2...28a5fc8. Read the comment docs.

@alongd
Copy link
Member Author

alongd commented Nov 1, 2020

@mjohnson541, could you approve that this addition fixes your issue?

@mjohnson541
Copy link
Collaborator

Unfortunately, this branch doesn't seem to fix it:

input.txt

output.txt

@mjohnson541
Copy link
Collaborator

So just running # cbs-qb3 geom=connectivity
seems to work properly, although ARC seems to have trouble recognizing that the output file is converged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulty with [H] (and perhaps other atomic species)
2 participants