Fix unicode handling in JSON serialization for SQLTrackerStore #12990
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the JSON serialization within the SQLTrackerStore to preserve non-ASCII characters such as Cyrillic script. By setting ensure_ascii=False in json.dumps, the data is now stored in its original representation, allowing for proper storage and retrieval of non-ASCII characters. This change addresses issues with Unicode encoding in the database, ensuring that intent and action names containing Cyrillic characters are correctly represented.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the JSON serialization within the SQLTrackerStore to preserve non-ASCII characters such as Cyrillic script. By setting ensure_ascii=False in json.dumps, the data is now stored in its original representation, allowing for proper storage and retrieval of non-ASCII characters. This change addresses issues with Unicode encoding in the database, ensuring that intent and action names containing Cyrillic characters are correctly represented.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)